Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: ensure SchemaField.field_dtype returns a string - #2188
Merged
Conversation
tswast
approved these changes
May 16, 2025
| "uint16": "INTEGER", | ||
| "uint32": "INTEGER", | ||
| "geometry": "GEOGRAPHY", | ||
| "string": "STRING", |
Contributor
There was a problem hiding this comment.
This dictionary should only get used if pandas-gbq is not installed. Let's make sure to make the same change here:
ContributorAuthor
There was a problem hiding this comment.
I undid the changes after discovering the root cause: the dataframe_to_bq_schema method incorrectly relies on None for SchemaField.field_dtype, which actually required a string value. Hence, this change refactors the dataframe_to_bq_schema a little bit.
chelsea-linforce-pushed
the
main_chelsealin_fieldtype
branch
from
May 16, 2025 18:58
b7696b3 to
adff18dComparechelsea-lin
marked this pull request as ready for review
May 16, 2025 19:04
chelsea-linforce-pushed
the
main_chelsealin_fieldtype
branch
from
May 16, 2025 20:09
adff18d to
aab12faComparetswast
approved these changes
May 16, 2025
chelsea-linforce-pushed
the
main_chelsealin_fieldtype
branch
from
May 16, 2025 20:45
aab12fa to
0ae6e09Compare
This was referenced May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.