Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: add total slot ms to RowIterator - #2233

Merged
chelsea-lin merged 4 commits into
googleapis:mainfrom
Genesis929:slot_ms_rowiterator
Jul 11, 2025
Merged

feat: add total slot ms to RowIterator#2233
chelsea-lin merged 4 commits into
googleapis:mainfrom
Genesis929:slot_ms_rowiterator

Conversation

@Genesis929

@Genesis929Genesis929 commented Jul 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

We need this for BigFrames, see #2234
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#2234

@Genesis929
Genesis929 requested review from a team and suzmueJuly 9, 2025 23:37
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Jul 9, 2025
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jul 9, 2025
@Genesis929
Genesis929 marked this pull request as draft July 9, 2025 23:37
@chalmerlowe
chalmerlowe requested review from chalmerlowe and removed request for suzmueJuly 10, 2025 15:23
chalmerlowe
chalmerlowe suggested changes Jul 10, 2025
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Genesis929

Github indicated that my review was requested, however...

it might just be a bit over eager...

  • the PR is still marked as draft
  • there is no description outlining why this change is being suggested

As soon as this PR has a description and moves out of Draft status, please let me know and I will gladly take a second look.

So far, everything I see seems good.

@Genesis929

Genesis929 commented Jul 10, 2025

Copy link
Copy Markdown
ContributorAuthor

@Genesis929

Github indicated that my review was requested, however...

it might just be a bit over eager...

  • the PR is still marked as draft
  • there is no description outlining why this change is being suggested

As soon as this PR has a description and moves out of Draft status, please let me know and I will gladly take a second look.

So far, everything I see seems good.

Thank you very much! Sorry for the trouble, I was going to create a draft, but I accidentally created a pull request, and have to change it back to draft.

@Genesis929
Genesis929 marked this pull request as ready for review July 10, 2025 17:25
chalmerlowe
chalmerlowe approved these changes Jul 10, 2025
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chelsea-lin
chelsea-lin merged commit d44bf02 into googleapis:mainJul 11, 2025
24 checks passed
@release-pleaserelease-pleaseBot mentioned this pull request Jul 11, 2025
Merged
This was referenced Jul 22, 2025
Closed
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@chalmerlowechalmerlowechalmerlowe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@shollymanshollyman

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add slot ms to RowIterator

5 participants

@Genesis929@chalmerlowe@shollyman@agrawal-siddharth@chelsea-lin