Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: add missing spaces in opentelemetry log message - #360

Merged
gcf-merge-on-green[bot] merged 2 commits into
googleapis:masterfrom
rickard-von-essen:patch-1
Nov 3, 2020
Merged

fix: add missing spaces in opentelemetry log message#360
gcf-merge-on-green[bot] merged 2 commits into
googleapis:masterfrom
rickard-von-essen:patch-1

Conversation

@rickard-von-essen

Copy link
Copy Markdown
Contributor

Currently this log message renders like this:

This service is instrumented using OpenTelemetry.OpenTelemetry could not be imported; pleaseadd opentelemetry-api and opentelemetry-instrumentationpackages in order to get BigQuery Tracing data.

where it should be

This service is instrumented using OpenTelemetry. OpenTelemetry could not be imported; please add opentelemetry-api and opentelemetry-instrumentation packages in order to get BigQuery Tracing data."

@rickard-von-essen
rickard-von-essen requested review from a team and shollymanNovember 3, 2020 13:00
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2020
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 3, 2020
@rickard-von-essen
rickard-von-essenforce-pushed the patch-1 branch 2 times, most recently from 0202861 to c8bd8cfCompareNovember 3, 2020 13:06
Currently this log message renders like this:
```
This service is instrumented using OpenTelemetry.OpenTelemetry could not be imported; pleaseadd
opentelemetry-api and opentelemetry-instrumentationpackages in order to get BigQuery Tracing data.
```
where it should be
```
This service is instrumented using OpenTelemetry. OpenTelemetry could not be imported; please add
opentelemetry-api and opentelemetry-instrumentation packages in order to get BigQuery Tracing data."
```
@tswasttswast added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2020
@yoshi-kokoroyoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2020
@tswasttswast changed the title Add missing spaces in log messagefix: add missing spaces in opentelemetry log messageNov 3, 2020
@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2020
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 4f326b1 into googleapis:masterNov 3, 2020
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rickard-von-essen@tswast@yoshi-kokoro