Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: add progress bar for magics - #396
Merged
Merged
Conversation
tswast
reviewed
Nov 30, 2020
| self._default_query_job_config = bigquery.QueryJobConfig() | ||
| self._bigquery_client_options = client_options.ClientOptions() | ||
| self._bqstorage_client_options = client_options.ClientOptions() | ||
| self._progress_bar_type = None |
Contributor
There was a problem hiding this comment.
I think tqdm would be fine default value here
ContributorAuthor
There was a problem hiding this comment.
If i put tqdm as a default value anywhere in the code, test_jupyter_tutorial(ipython) snippet failed, you can see in the first commit. It's because tqdm is not installed.
Contributor
There was a problem hiding this comment.
That's because there's a bug in the progress bar code.
if progress_bar_type is None:
return query_job.result()
This is too soon to check if a progress bar can be supported. We should check if progress_bar is None after
progress_bar = get_progress_bar(
progress_bar_type, "Query is running", default_total, "query"
)
Something like
"""Return query result and display a progress bar while the query running, if tqdm is installed."""
progress_bar = get_progress_bar(
progress_bar_type, "Query is running", default_total, "query"
)
if progress_bar is None:
return query_job.result()
default_total = 1
current_stage = None
start_time = time.time()
tswast
approved these changes
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#389