Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: support CSV format in load_table_from_dataframe pandas connector - #399

Merged
tswast merged 8 commits into
googleapis:masterfrom
cguardia:383-load-table-from-dataframe-csv
Dec 7, 2020
Merged

feat: support CSV format in load_table_from_dataframe pandas connector#399
tswast merged 8 commits into
googleapis:masterfrom
cguardia:383-load-table-from-dataframe-csv

Conversation

@cguardia

@cguardiacguardia commented Nov 24, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

for load_table_from_dataframe

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#383 🦕

@cguardia
cguardia requested review from a team and steffnayNovember 24, 2020 09:40
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 24, 2020
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 24, 2020
@cguardiacguardia mentioned this pull request Nov 24, 2020
Closed
tswast
tswast reviewed Nov 24, 2020
View reviewed changes
Comment threadgoogle/cloud/bigquery/client.py Outdated
Comment threadgoogle/cloud/bigquery/client.py Outdated
Comment threadgoogle/cloud/bigquery/client.py Outdated
Comment threadtests/system.py Outdated
Comment threadtests/system.py
@cguardia

cguardia commented Dec 2, 2020

Copy link
Copy Markdown
ContributorAuthor

@tswast sorry for the delay. I think this addresses your comments.

tswast
tswast reviewed Dec 3, 2020
View reviewed changes
Comment threadgoogle/cloud/bigquery/client.py
@tswasttswast changed the title WIP: support alternative serialization formatsfeat: support CSV format in load_table_from_dataframe pandas connectorDec 7, 2020
@tswast
tswast merged commit 0046742 into googleapis:masterDec 7, 2020
@tswasttswast mentioned this pull request Dec 21, 2020
Closed
@release-pleaserelease-pleaseBot mentioned this pull request Jan 4, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steffnaysteffnayAwaiting requested review from steffnay
1 more reviewer
@tswasttswasttswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

load_table_from_dataframe -- support alternative serialization formats

2 participants

@cguardia@tswast