Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
perf: don't fetch rows when waiting for query to finish - #400
Merged
gcf-merge-on-green[bot] merged 7 commits intoNov 24, 2020
Merged
Conversation
When there are large result sets, fetching rows while waiting for the query to finish can cause the API to hang indefinitely. (This may be due to an interaction between connection timeout and API timeout.) This reverts commit 86f6a51 (googleapis#374).
tswast
commented
Nov 24, 2020
| api_request.assert_called_once_with(method="GET", path=path, query_params={}) | ||
| def test_iterate_with_cached_first_page(self): |
ContributorAuthor
There was a problem hiding this comment.
I add these tests to fix coverage.
Perhaps instead I should also be reverting the changes from #384 ?
Contributor
There was a problem hiding this comment.
The alternative I'd consider is doing a flag-based feature, so users can turn on the latency changes (or flip default, and provide an opt-out while we diagnose these other cases).
shollyman
approved these changes
Nov 24, 2020
| api_request.assert_called_once_with(method="GET", path=path, query_params={}) | ||
| def test_iterate_with_cached_first_page(self): |
Contributor
There was a problem hiding this comment.
The alternative I'd consider is doing a flag-based feature, so users can turn on the latency changes (or flip default, and provide an opt-out while we diagnose these other cases).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are large result sets, fetching rows while waiting for the
query to finish can cause the API to hang indefinitely. (This may be due
to an interaction between connection timeout and API timeout.)
This reverts commit 86f6a51 (#374).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixesgoogleapis/python-bigquery-pandas#343
Fixes#394 🦕