Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: add support for unrecognized model types - #401

Merged
steffnay merged 3 commits into
googleapis:masterfrom
steffnay:model-const
Nov 30, 2020
Merged

feat: add support for unrecognized model types#401
steffnay merged 3 commits into
googleapis:masterfrom
steffnay:model-const

Conversation

@steffnay

@steffnaysteffnay commented Nov 25, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

If fails to parse model type enum, sets to MODEL_TYPE_UNSPECIFIED.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#334 🦕

@steffnay
steffnay requested review from a team and pmakaniNovember 25, 2020 13:15
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 25, 2020
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2020
@steffnay
steffnay requested a review from tswastNovember 25, 2020 14:23
tswast
tswast approved these changes Nov 30, 2020
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@steffnay
steffnay merged commit 168f035 into googleapis:masterNov 30, 2020
@release-pleaserelease-pleaseBot mentioned this pull request Jan 4, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pmakanipmakaniAwaiting requested review from pmakani
1 more reviewer
@tswasttswasttswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Model constructor robust against new model types

2 participants

@steffnay@tswast