Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: error using empty array of structs parameter - #474

Merged
tswast merged 15 commits into
googleapis:masterfrom
plamut:iss-463
Feb 24, 2021
Merged

fix: error using empty array of structs parameter#474
tswast merged 15 commits into
googleapis:masterfrom
plamut:iss-463

Conversation

@plamut

@plamutplamut commented Jan 19, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#463.

This PR adds an optional type info parameter to ArrayQueryParameter so that array query parameters with STRUCT items can be used in queries even if they are empty. This is a solution similar to the one used in e.g. the Ruby client.

(for non-struct items the type can always be determined by using the array_type argument)

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut
plamut requested review from a team and stephaniewang526 and removed request for a teamJanuary 19, 2021 12:43
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jan 19, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jan 19, 2021
@plamutplamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 19, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 19, 2021
tswast
tswast suggested changes Jan 22, 2021
View reviewed changes
Comment threadgoogle/cloud/bigquery/query.py Outdated
@plamut
plamut requested a review from tswastFebruary 4, 2021 12:03
tswast
tswast suggested changes Feb 19, 2021
View reviewed changes
Comment threadgoogle/cloud/bigquery/query.py Outdated
Comment threadgoogle/cloud/bigquery/query.py
Comment threadgoogle/cloud/bigquery/query.py
raise NotImplementedError


class ScalarQueryParameterType(_AbstractQueryParameterType):

@tswasttswastFeb 19, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do this in this PR, but I'm tempted to ask for an additional set of constants in google.cloud.bigquery.enums that has all the scalar types defined as objects (without name & description). I imagine that will be useful when we eventually create an "array of structs query parameter" code sample.

@plamutplamutFeb 20, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, let's do it in a follow-up PR. 👍

Edit: It's actually very straightforward (if I understood it correctly, that is), thus added that in an extra commit.

Comment threadgoogle/cloud/bigquery/query.py Outdated
Comment threadgoogle/cloud/bigquery/query.py Outdated
@plamut
plamut requested a review from tswastFebruary 20, 2021 12:15
tswast
tswast approved these changes Feb 24, 2021
View reviewed changes
Comment threadgoogle/cloud/bigquery/enums.py
DATETIME = "DATETIME"


class SqlParameterScalarTypes:

@tswasttswastFeb 24, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@tswast
tswast merged commit c1d15f4 into googleapis:masterFeb 24, 2021
gcf-merge-on-greenBot pushed a commit that referenced this pull request Feb 25, 2021
@release-please
chore: release 2.10.0 (#533)
81df4ba
🤖 I have created a release \*beep\* \*boop\* ---
## [2.10.0](https://www.github.com/googleapis/python-bigquery/compare/v2.9.0...v2.10.0) (2021-02-25)
### Features
* add BIGNUMERIC support ([#527](https://www.github.com/googleapis/python-bigquery/issues/527)) ([cc3394f](https://www.github.com/googleapis/python-bigquery/commit/cc3394f80934419eb00c2029bb81c92a696e7d88))
### Bug Fixes
* error using empty array of structs parameter ([#474](https://www.github.com/googleapis/python-bigquery/issues/474)) ([c1d15f4](https://www.github.com/googleapis/python-bigquery/commit/c1d15f4e5da4b7e10c00afffd59a5c7f3ded027a))
* QueryJob.exception() *returns* the errors, not raises them ([#467](https://www.github.com/googleapis/python-bigquery/issues/467)) ([d763279](https://www.github.com/googleapis/python-bigquery/commit/d7632799769248b09a8558ba18f5025ebdd9675a))
### Documentation
* **bigquery:** Add alternative approach to setting credentials ([#517](https://www.github.com/googleapis/python-bigquery/issues/517)) ([60fbf28](https://www.github.com/googleapis/python-bigquery/commit/60fbf287b0d34d5db2e61cce7a5b42735ed43d0e))
* explain retry behavior for DONE jobs ([#532](https://www.github.com/googleapis/python-bigquery/issues/532)) ([696c443](https://www.github.com/googleapis/python-bigquery/commit/696c443f0a6740be0767e12b706a7771bc1460c3))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@plamut
plamut deleted the iss-463 branch February 26, 2021 07:49
@release-pleaserelease-pleaseBot mentioned this pull request Jan 4, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephaniewang526stephaniewang526Awaiting requested review from stephaniewang526
1 more reviewer
@tswasttswasttswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support arrays of record/structs as query parameters

3 participants

@plamut@tswast@yoshi-kokoro