Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: add BIGNUMERIC support - #527

Merged
tswast merged 9 commits into
googleapis:masterfrom
plamut:iss-367
Feb 23, 2021
Merged

feat: add BIGNUMERIC support#527
tswast merged 9 commits into
googleapis:masterfrom
plamut:iss-367

Conversation

@plamut

Copy link
Copy Markdown
Contributor

Closes#367.

This is a continuation of #447 that adds extra tests and a few final touches.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut
plamut requested review from a team and shollyman and removed request for a teamFebruary 18, 2021 13:28
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Feb 18, 2021
@google-cla

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-clagoogle-claBot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 18, 2021
@plamut

Copy link
Copy Markdown
ContributorAuthor

@HemangChothani If you see this, can you please confirm to the bot that you consent using your commits? (this PR builds on top of your work)

Thanks!

@google-cla

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@plamut

Copy link
Copy Markdown
ContributorAuthor

Tests will have to be refactored to not assume pyarrow>=3.0.0 is available (they fail when they are run with pyarrow==1.0.0) - the BIGNUMERIC fixtures and assertions need to be moved out and skipped conditionally.

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! One suggestion regarding the version comparison. We also will need some skipifs. Might be able to do those based on the pattern we have in google-auth, with a private constant that indicates if the BIGNUMERIC feature is available.

Comment threadgoogle/cloud/bigquery/_pandas_helpers.py Outdated
Comment threadgoogle/cloud/bigquery/_pandas_helpers.py Outdated
Comment threadgoogle/cloud/bigquery/dbapi/_helpers.py
@google-cla

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@plamut
plamut requested a review from tswastFebruary 19, 2021 11:18

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but otherwise looks good

Comment threadsetup.py
@plamut

plamut commented Feb 23, 2021

Copy link
Copy Markdown
ContributorAuthor

@shollyman Can you please take a look at the CLA? The PR is a continuation of #447 which was opened by an existing maintainer, but I do see that the CLA check has failed there even though the PR was submitted before the before the new year.

(to date the original author has not yet responded here)

@tswast

Copy link
Copy Markdown
Contributor

"CLAs are signed, but unable to verify author consent"

Since these commits were pulled from #447, I'm going to call that author consent and mark the label as true.

@tswasttswast added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 23, 2021
@tswast
tswast merged commit cc3394f into googleapis:masterFeb 23, 2021
@plamut
plamut deleted the iss-367 branch February 23, 2021 19:24
gcf-merge-on-greenBot pushed a commit that referenced this pull request Feb 25, 2021
🤖 I have created a release \*beep\* \*boop\* ---
## [2.10.0](https://www.github.com/googleapis/python-bigquery/compare/v2.9.0...v2.10.0) (2021-02-25)
### Features
* add BIGNUMERIC support ([#527](https://www.github.com/googleapis/python-bigquery/issues/527)) ([cc3394f](https://www.github.com/googleapis/python-bigquery/commit/cc3394f80934419eb00c2029bb81c92a696e7d88))
### Bug Fixes
* error using empty array of structs parameter ([#474](https://www.github.com/googleapis/python-bigquery/issues/474)) ([c1d15f4](https://www.github.com/googleapis/python-bigquery/commit/c1d15f4e5da4b7e10c00afffd59a5c7f3ded027a))
* QueryJob.exception() *returns* the errors, not raises them ([#467](https://www.github.com/googleapis/python-bigquery/issues/467)) ([d763279](https://www.github.com/googleapis/python-bigquery/commit/d7632799769248b09a8558ba18f5025ebdd9675a))
### Documentation
* **bigquery:** Add alternative approach to setting credentials ([#517](https://www.github.com/googleapis/python-bigquery/issues/517)) ([60fbf28](https://www.github.com/googleapis/python-bigquery/commit/60fbf287b0d34d5db2e61cce7a5b42735ed43d0e))
* explain retry behavior for DONE jobs ([#532](https://www.github.com/googleapis/python-bigquery/issues/532)) ([696c443](https://www.github.com/googleapis/python-bigquery/commit/696c443f0a6740be0767e12b706a7771bc1460c3))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BIGNUMERIC support

3 participants

@plamut@tswast@HemangChothani