Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: remove default timeout - #974
Merged
Merged
Conversation
Internal folks, see: go/microgenerator-retries "Methods will **not** hedge by default." (emphasis mine)
plamut
reviewed
Sep 20, 2021
plamut
left a comment
Contributor
There was a problem hiding this comment.
Has this been confirmed internally as the root cause for the issue the user was facing?
The code change itself looks good.
tswast
commented
Sep 20, 2021
ContributorAuthor
SRE and API core teams recommends not setting default timeout. Client should still be able to set timeouts in the case when an operation needs to finish within a certain time or else fail. |
tswast
commented
Sep 20, 2021
ContributorAuthor
In the internal go/microgenerator-retries document, default timeouts + retrying on timeout error is defined as a form of hedging, which is not supposed to happen in our clients. |
plamut
commented
Sep 21, 2021
Contributor
Thanks for elaborating, let's merge it then. |
plamut
approved these changes
Sep 21, 2021
abdelmegahedgoogle pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
Internal folks, see: go/microgenerator-retries > "Methods will **not** hedge by default." (emphasis mine) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixesgoogleapis#970 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal folks, see: go/microgenerator-retries
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes#970 🦕