Skip to content
This repository was archived by the owner on Feb 13, 2026. It is now read-only.

Feat: Client should pass client_options.api_key to auth library - #321

Merged
parthea merged 9 commits into
mainfrom
api_key
Feb 13, 2025
Merged

Feat: Client should pass client_options.api_key to auth library#321
parthea merged 9 commits into
mainfrom
api_key

Conversation

@andrewsg

@andrewsgandrewsg commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

Fixes#319 🦕

@andrewsg
andrewsg requested a review from a teamFebruary 11, 2025 01:04
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Feb 11, 2025
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 11, 2025
parthea
parthea reviewed Feb 13, 2025
View reviewed changes

@partheaparthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but holding off on formal approval until comments are addressed

Comment threadgoogle/cloud/client/__init__.py Outdated
Comment threadgoogle/cloud/client/__init__.py Outdated
Comment threadgoogle/cloud/client/__init__.py Outdated
Comment threadsetup.py Outdated
Comment threadtesting/constraints-3.7.txt Outdated
Comment thread.kokoro/docker/docs/requirements.txt
@andrewsg

andrewsg commented Feb 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks! Applied suggestions, PTAL.

@parthea
parthea merged commit dfac15b into mainFeb 13, 2025
@parthea
parthea deleted the api_key branch February 13, 2025 19:39
@release-pleaserelease-pleaseBot mentioned this pull request Feb 13, 2025
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@partheapartheaparthea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@partheaparthea

Labels

size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If api_key is set in client options, pass it through to auth

2 participants

@andrewsg@parthea