Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

feat: Switch to string enums for compute (#685) - #158

Merged
parthea merged 12 commits into
mainfrom
owl-bot-9f21b9c6-54f2-4ee3-aea7-8cf1787e04e0
Nov 29, 2021
Merged

feat: Switch to string enums for compute (#685)#158
parthea merged 12 commits into
mainfrom
owl-bot-9f21b9c6-54f2-4ee3-aea7-8cf1787e04e0

Conversation

@gcf-owl-bot

Copy link
Copy Markdown
Contributor
  • Regenerate this pull request now.

Also introduce gapic_yaml for java clients to override default LRO configuration (which has too way too long timeouts).

Also cleanup regenerate other files (grpc_service_config and service yaml)
Source-Link: googleapis/googleapis@8ce4ea6

Source-Link: https://github.com/googleapis/googleapis-gen/commit/55e242c7cf5e600fabb8d767bd06f4fdfad6a015
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTVlMjQyYzdjZjVlNjAwZmFiYjhkNzY3YmQwNmY0ZmRmYWQ2YTAxNSJ9

Also introduce gapic_yaml for java clients to override default LRO configuration (which has too way too long timeouts).
Also cleanup regenerate other files (grpc_service_config and service yaml)
Source-Link: googleapis/googleapis@8ce4ea6
Source-Link: https://github.com/googleapis/googleapis-gen/commit/55e242c7cf5e600fabb8d767bd06f4fdfad6a015
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTVlMjQyYzdjZjVlNjAwZmFiYjhkNzY3YmQwNmY0ZmRmYWQ2YTAxNSJ9
@gcf-owl-bot
gcf-owl-botBot requested review from a teamNovember 19, 2021 02:48
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 19, 2021
@product-auto-labelproduct-auto-labelBot added the api: compute Issues related to the googleapis/python-compute API. label Nov 19, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 19, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 19, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 19, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 19, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 19, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@partheaparthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 19, 2021

@partheaparthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests are failing

@gcf-owl-bot
gcf-owl-botBot requested review from a team and m-strzelczyk as code ownersNovember 25, 2021 10:20
@gcf-owl-bot
gcf-owl-botBot requested a review from nicainNovember 25, 2021 10:20
@partheaparthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 25, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 25, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@yoshi-kokoroyoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 25, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 25, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 25, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 25, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 25, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2021
@parthea

Copy link
Copy Markdown
Contributor

@m-strzelczyk Please could you review/approve?

@release-pleaserelease-pleaseBot mentioned this pull request Jan 13, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: computeIssues related to the googleapis/python-compute API.cla: yesThis human has signed the Contributor License Agreement.owl-bot-copy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea@m-strzelczyk@yoshi-kokoro