Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

feat: support not_equal queries for none and nan - #988

Merged
daniel-sanche merged 8 commits into
mainfrom
is_not_null_operator
Jan 13, 2025
Merged

feat: support not_equal queries for none and nan#988
daniel-sanche merged 8 commits into
mainfrom
is_not_null_operator

Conversation

@daniel-sanche

Copy link
Copy Markdown
Contributor

Building off of #971

allow != for None and Nan comparisons:

  • x.where("field", "!=", None)
  • x.where("field", "!=", float(nan))

Fixes#970

Thanks @mgraczyk!

@daniel-sanche
daniel-sanche requested review from a teamDecember 20, 2024 00:41
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/python-firestore API. labels Dec 20, 2024
@daniel-sanchedaniel-sanche changed the title Is not null operatorfeat: support not_equal for none and nanDec 20, 2024
@daniel-sanchedaniel-sanche changed the title feat: support not_equal for none and nanfeat: support not_equal queries for none and nanDec 20, 2024
@mgraczyk

Copy link
Copy Markdown
Contributor

Thanks for working on this!

@daniel-sanche
daniel-sanche merged commit cbaf4ae into mainJan 13, 2025
@daniel-sanche
daniel-sanche deleted the is_not_null_operator branch January 13, 2025 19:39
@release-pleaserelease-pleaseBot mentioned this pull request Jan 13, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestoreIssues related to the googleapis/python-firestore API.size: mPull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement IS_NOT_NULL

5 participants

@daniel-sanche@mgraczyk@gkevinzheng@cindy-peng@tom-andersen