Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 13, 2026. It is now read-only.
feat: support Django asgi middleware - #625
Merged
Merged
Conversation
daniel-sanche
marked this pull request as ready for review
October 3, 2022 17:39
glasnt
approved these changes
Oct 5, 2022
glasnt
left a comment
Contributor
There was a problem hiding this comment.
Tested applying these fixes on Django deployed on Cloud Run and App Engine. Works as expected on each platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#607
This PR updates our old deprecated
MiddlewareMixinDjango middleware to use the current best practices, which fixes a crashing bug when using modern asgi webservers