Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

fix: json fields dictionary has modification side effect - #654

Merged
daniel-sanche merged 4 commits into
mainfrom
fix_json_fields_sideeffects
Oct 25, 2022
Merged

fix: json fields dictionary has modification side effect#654
daniel-sanche merged 4 commits into
mainfrom
fix_json_fields_sideeffects

Conversation

@daniel-sanche

@daniel-sanchedaniel-sanche commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

Fixes#652

Based on this original PR, with some unit tests added (thanks @mat105!)

@daniel-sanche
daniel-sanche requested review from a teamOctober 24, 2022 20:40
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Oct 24, 2022
@product-auto-labelproduct-auto-labelBot added the api: logging Issues related to the googleapis/python-logging API. label Oct 24, 2022
losalex
losalex reviewed Oct 24, 2022
View reviewed changes
Comment threadgoogle/cloud/logging_v2/handlers/handlers.py
losalex
losalex approved these changes Oct 25, 2022
View reviewed changes

@losalexlosalex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@losalexlosalex changed the title fix: json fields dictionary has modification side eddectfix: json fields dictionary has modification side effectOct 25, 2022
@daniel-sanche
daniel-sanche merged commit a62a0d6 into mainOct 25, 2022
@daniel-sanche
daniel-sanche deleted the fix_json_fields_sideeffects branch October 25, 2022 16:13
@release-pleaserelease-pleaseBot mentioned this pull request Oct 25, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@losalexlosalexlosalex approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@losalexlosalex

Labels

api: loggingIssues related to the googleapis/python-logging API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generate a copy of json_fields before adding message

2 participants

@daniel-sanche@losalex