Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

feat: use native namespaces instead of pkg_resources - #812

Merged
parthea merged 5 commits into
mainfrom
native-namespace
Nov 29, 2023
Merged

feat: use native namespaces instead of pkg_resources#812
parthea merged 5 commits into
mainfrom
native-namespace

Conversation

@gkevinzheng

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#730 🦕

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: logging Issues related to the googleapis/python-logging API. labels Nov 15, 2023
@gkevinzheng
gkevinzheng marked this pull request as ready for review November 16, 2023 18:20
@gkevinzheng
gkevinzheng requested review from a teamNovember 16, 2023 18:20
@partheaparthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 16, 2023
@parthea

Copy link
Copy Markdown
Contributor

Adding do not merge as there is an upcoming release freeze. This should be merged after the release freeze ends on November 29th.

@partheaparthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please could you add tests as well similar to googleapis/google-auth-library-python#1205?

@partheaparthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 29, 2023
@parthea
parthea enabled auto-merge (squash) November 29, 2023 17:26
@parthea
parthea merged commit 10ad75d into mainNov 29, 2023
@parthea
parthea deleted the native-namespace branch November 29, 2023 17:41
@release-pleaserelease-pleaseBot mentioned this pull request Nov 29, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: loggingIssues related to the googleapis/python-logging API.size: mPull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeprecationWarning for pkg_resources.declare_namespace("google.logging")

3 participants

@gkevinzheng@parthea@daniel-sanche