Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

fix: Add emulator support to schema service - #658

Merged
acocuzzo merged 17 commits into
googleapis:mainfrom
acocuzzo:support-emulator-schema-service
May 10, 2022
Merged

fix: Add emulator support to schema service#658
acocuzzo merged 17 commits into
googleapis:mainfrom
acocuzzo:support-emulator-schema-service

Conversation

@acocuzzo

@acocuzzoacocuzzo commented Apr 15, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Adding schema_service/client.py to clients_to_patch in owlbot.py to add emulator support.

Fixes#647🦕

@acocuzzo
acocuzzo requested review from a teamApril 15, 2022 15:49
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Apr 15, 2022
@acocuzzoacocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2022
@acocuzzoacocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2022
@acocuzzo
acocuzzo marked this pull request as draft April 15, 2022 15:52
@product-auto-labelproduct-auto-labelBot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels Apr 18, 2022
@acocuzzoacocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 18, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 18, 2022
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. and removed size: xl Pull request size is extra large. labels Apr 18, 2022
@acocuzzoacocuzzo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 18, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 18, 2022
@acocuzzoacocuzzo changed the title fix: add emulator support to schema servicefix: Add emulator support to schema serviceApr 18, 2022
@googleapisgoogleapis deleted a comment from snippet-botBotApr 18, 2022
@acocuzzoacocuzzo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 20, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 20, 2022
@acocuzzoacocuzzo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2022
@acocuzzo
acocuzzo marked this pull request as ready for review April 21, 2022 20:39
@acocuzzo
acocuzzo requested a review from a team as a code ownerApril 21, 2022 20:39
@acocuzzo
acocuzzo requested a review from partheaApril 21, 2022 20:39
pradn
pradn approved these changes May 10, 2022
View reviewed changes

@pradnpradn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider putting import grpc back where it was. Otherwise, looks good.

@acocuzzo
acocuzzo merged commit 1a07d7c into googleapis:mainMay 10, 2022
@release-pleaserelease-pleaseBot mentioned this pull request May 10, 2022
Merged
@release-pleaserelease-pleaseBot mentioned this pull request Aug 11, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@partheapartheaAwaiting requested review from partheaparthea was automatically assigned from googleapis/python-samples-owners
1 more reviewer
@pradnpradnpradn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Schema api not supporting pubsub emulator

3 participants

@acocuzzo@pradn@yoshi-kokoro