Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 9, 2026. It is now read-only.
fix: set stream_ack_deadline to max_duration_per_lease_extension or 60 s, set ack_deadline to min_duration_per_lease_extension or 10 s - #760
Merged
Conversation
maheshgattani
approved these changes
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When max_duration_per_lease_extension is set and within the 10 - 600 secs, the stream_ack_deadline will be set to max_duration_per_lease_extension, otherwise it will be set to 60 seconds to match Java client library behavior.
When min_duration_per_lease_extension is set and within the 10 - 600 sec, the ack_deadline will be initialized with this value, otherwise it will default to 10 sec.
Fixes#758🦕