Skip to content

feat: Publish idempotence - #408

Merged
tmdiep merged 5 commits into
googleapis:mainfrom
tmdiep:idempotence
Mar 21, 2023
Merged

feat: Publish idempotence#408
tmdiep merged 5 commits into
googleapis:mainfrom
tmdiep:idempotence

Conversation

@tmdiep

@tmdieptmdiep commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

Implements publish idempotence (default enabled), where the server will ensure that unique messages within a single publisher session are only stored once.

@tmdiep
tmdiep requested review from a teamFebruary 17, 2023 09:18
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. api: pubsublite Issues related to the googleapis/python-pubsublite API. labels Feb 17, 2023
@partheaparthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 17, 2023
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 17, 2023
dpcollins-google
dpcollins-google approved these changes Feb 20, 2023
View reviewed changes
Comment threadgoogle/cloud/pubsublite/internal/wire/single_partition_publisher.py Outdated
Comment threadgoogle/cloud/pubsublite/internal/wire/single_partition_publisher.py Outdated
Comment threadgoogle/cloud/pubsublite/internal/wire/single_partition_publisher.py Outdated
Comment threadgoogle/cloud/pubsublite/internal/wire/single_partition_publisher.py Outdated
Comment threadgoogle/cloud/pubsublite/internal/wire/single_partition_publisher.py Outdated
Comment threadgoogle/cloud/pubsublite/internal/wire/single_partition_publisher.py Outdated
Comment threadgoogle/cloud/pubsublite/internal/wire/single_partition_publisher.py Outdated
@tmdieptmdiep added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2023
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2023
@tmdiep
tmdiep merged commit 3236752 into googleapis:mainMar 21, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Mar 21, 2023
Merged
@tmdiep
tmdiep deleted the idempotence branch March 21, 2023 13:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dpcollins-googledpcollins-googledpcollins-google approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubliteIssues related to the googleapis/python-pubsublite API.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmdiep@dpcollins-google@parthea