Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

feat: implement get_view_names() method - #306

Merged
gcf-merge-on-green[bot] merged 19 commits into
mainfrom
view_names
Mar 20, 2023
Merged

feat: implement get_view_names() method#306
gcf-merge-on-green[bot] merged 19 commits into
mainfrom
view_names

Conversation

@IlyaFaer

Copy link
Copy Markdown

Closes#303

@IlyaFaerIlyaFaer added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 7, 2023
@product-auto-labelproduct-auto-labelBot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Feb 7, 2023
@IlyaFaer
IlyaFaer marked this pull request as ready for review February 7, 2023 06:09
@IlyaFaer

Copy link
Copy Markdown
Author

@asthamohta, this also adds small changes to make the test suites ignore SQLAlchemy 2.0 as it includes a lot of breaking changes.

One strange thing I noticed is that the SQL query

SELECT table_name
FROMinformation_schema.views

Returns lists of strings. Is the information_schema.views.table_name field has the correct type? It feels like it's type is ARRAY<STRING>, not just STRING.

@asthamohtaasthamohta added the automerge Merge the pull request once unit tests and other checks pass. label Feb 8, 2023
@gcf-merge-on-green

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 8, 2023
@IlyaFaerIlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2023
@IlyaFaerIlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2023
@yoshi-kokoroyoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 13, 2023
@yu-iskw

Copy link
Copy Markdown

I don't know what kokoro is like at all. However, according to the error message, it was failed due to timeout apparently.

ERROR: Aborting VM command due to timeout of 10800 seconds

@yu-iskw

Copy link
Copy Markdown

@asthamohta Is there anything I can help? I would like to go ahead with the issue.

@asthamohtaasthamohta added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Mar 20, 2023
@asthamohtaasthamohta added the automerge Merge the pull request once unit tests and other checks pass. label Mar 20, 2023
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 63461e6 into mainMar 20, 2023
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the view_names branch March 20, 2023 22:50
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 20, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spannerIssues related to the googleapis/python-spanner-sqlalchemy API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support get_view_names

4 participants

@IlyaFaer@yu-iskw@asthamohta@yoshi-kokoro