Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: return list of dictionaries for execute streaming sql - #1003

Merged
asthamohta merged 8 commits into
googleapis:mainfrom
asthamohta:issue-958
Oct 25, 2023
Merged

feat: return list of dictionaries for execute streaming sql#1003
asthamohta merged 8 commits into
googleapis:mainfrom
asthamohta:issue-958

Conversation

@asthamohta

@asthamohtaasthamohta commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@asthamohta
asthamohta requested review from a teamAugust 17, 2023 06:27
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. labels Aug 17, 2023
@asthamohtaasthamohta linked an issue Aug 17, 2023 that may be closed by this pull request
Is there an option to return execute_sql results as a list of dictionaries? #958
Closed
surbhigarg92
surbhigarg92 reviewed Aug 17, 2023
View reviewed changes
Comment threadgoogle/cloud/spanner_v1/streamed.py Outdated
Comment threadgoogle/cloud/spanner_v1/streamed.py
Comment threadgoogle/cloud/spanner_v1/streamed.py

def fetch_as_dictionary_list(self):
rows = []
for row in self:

@surbhigarg92surbhigarg92Aug 17, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if rows are not fully processed when this method is called ?

@asthamohtaasthamohtaAug 18, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be a delay in returning the result in those cases but always the full result will be returned

@asthamohta
asthamohta enabled auto-merge (squash) September 28, 2023 06:23
@asthamohta
asthamohta merged commit b534a8a into googleapis:mainOct 25, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Oct 25, 2023
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@surbhigarg92surbhigarg92surbhigarg92 left review comments
@rajatbhattarajatbhattarajatbhatta approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spannerIssues related to the googleapis/python-spanner API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is there an option to return execute_sql results as a list of dictionaries?

3 participants

@asthamohta@surbhigarg92@rajatbhatta