Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: Batch Write API implementation and samples - #1027

Merged
harshachinta merged 20 commits into
googleapis:mainfrom
sunny1612:feat-batch-write
Dec 3, 2023
Merged

feat: Batch Write API implementation and samples#1027
harshachinta merged 20 commits into
googleapis:mainfrom
sunny1612:feat-batch-write

Conversation

@ghost

@ghostghost commented Oct 19, 2023•
edited by harshachinta
Loading

Copy link
Copy Markdown

This PR adds code changes and samples for Batch Write feature.
https://cloud.google.com/spanner/docs/batch-write

@ghost
ghost self-requested a review as a code ownerOctober 19, 2023 10:04
@ghost
ghost requested review from a team and ohmayrOctober 19, 2023 10:04
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Oct 19, 2023
@snippet-bot

snippet-botBot commented Oct 19, 2023•
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@ghost

ghost commented Oct 19, 2023

Copy link
Copy Markdown
Author

@harshachinta - Can you please review this PR?

@ghost
ghost force-pushed the feat-batch-write branch from d47b9f2 to a32dd63CompareOctober 20, 2023 06:52
@ghost
ghost force-pushed the feat-batch-write branch from 0f0d42f to 96e6e15CompareNovember 2, 2023 11:24
@ghost

ghost commented Nov 14, 2023

Copy link
Copy Markdown
Author

@harshachinta - Can you please review this PR?

@harshachinta / @surbhigarg92 - Can you please take a look?

harshachinta
harshachinta reviewed Nov 16, 2023
View reviewed changes
Comment threadgoogle/cloud/spanner_v1/batch.py
harshachinta
harshachinta reviewed Nov 16, 2023
View reviewed changes
Comment threadgoogle/cloud/spanner_v1/batch.py Outdated
harshachinta
harshachinta reviewed Nov 16, 2023
View reviewed changes
Comment threadgoogle/cloud/spanner_v1/batch.py
harshachinta
harshachinta reviewed Nov 16, 2023
View reviewed changes
Comment threadgoogle/cloud/spanner_v1/database.py
harshachinta
harshachinta reviewed Nov 16, 2023
View reviewed changes
Comment threadgoogle/cloud/spanner_v1/database.py
harshachinta
harshachinta reviewed Nov 16, 2023
View reviewed changes
Comment threadgoogle/cloud/spanner_v1/database.py
harshachinta
harshachinta reviewed Nov 16, 2023
View reviewed changes

@harshachintaharshachinta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look the implementation changes. Will take a look at tests tomorrow.

harshachinta
harshachinta reviewed Nov 16, 2023
View reviewed changes
Comment threadgoogle/cloud/spanner_v1/batch.py Outdated
@ghost
ghost requested a review from harshachintaNovember 17, 2023 08:41
harshachinta
harshachinta reviewed Nov 29, 2023
View reviewed changes
Comment threadgoogle/cloud/spanner_v1/batch.py Outdated
harshachinta
harshachinta reviewed Nov 29, 2023
View reviewed changes
Comment threadgoogle/cloud/spanner_v1/batch.py Outdated
@harshachintaharshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2023
harshachinta
harshachinta reviewed Dec 1, 2023
View reviewed changes
Comment threadtests/unit/test_database.py
@harshachintaharshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2023
@harshachinta

harshachinta commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

@sunnsing-google
LGTM overall, except for one comment on correct mock response. Presubmits are failing and I am trying to figure out the issue.
Will approve once the presubmits get fixed.

@harshachintaharshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2023
@ghost

ghost commented Dec 1, 2023

Copy link
Copy Markdown
Author

@sunnsing-google LGTM overall, except for one comment on correct mock response. Presubmits are failing and I am trying to figure out the issue. Will approve once the presubmits get fixed.

Thanks. PR is updated with the test change. PTAL.

@harshachintaharshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2023
@harshachintaharshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2023
@harshachintaharshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2023
@harshachintaharshachinta added do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 3, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2023
@harshachintaharshachinta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 3, 2023
@harshachinta
harshachinta merged commit aa36b07 into googleapis:mainDec 3, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Dec 3, 2023
Merged
@ghost
ghost deleted the feat-batch-write branch December 3, 2023 19:04
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ohmayrohmayrAwaiting requested review from ohmayrohmayr is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

No one assigned

Labels

api: spannerIssues related to the googleapis/python-spanner API.samplesIssues that are directly related to samples.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harshachinta@yoshi-kokoro@sunny1612