Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

fix: Executing existing DDL statements on executemany statement execution - #1032

Merged
olavloite merged 6 commits into
googleapis:mainfrom
ankiaga:executemany_ddl_fix
Nov 17, 2023
Merged

fix: Executing existing DDL statements on executemany statement execution#1032
olavloite merged 6 commits into
googleapis:mainfrom
ankiaga:executemany_ddl_fix

Conversation

@ankiaga

@ankiagaankiaga commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

@ankiaga
ankiaga requested review from a teamNovember 8, 2023 09:07
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. labels Nov 8, 2023
@ankiagaankiaga changed the title Executing existing DDL statements on executemany statement executionfix: Executing existing DDL statements on executemany statement executionNov 8, 2023
@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Nov 8, 2023

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

olavloite
olavloite reviewed Nov 8, 2023
View reviewed changes
Comment threadgoogle/cloud/spanner_dbapi/cursor.py
Comment threadgoogle/cloud/spanner_dbapi/cursor.py
Comment threadtests/system/test_dbapi.py Outdated
Comment threadtests/system/test_dbapi.py Outdated
Comment threadtests/system/test_dbapi.py Outdated
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 9, 2023
olavloite
olavloite reviewed Nov 10, 2023
View reviewed changes
Comment threadtests/system/test_dbapi.py Outdated
olavloite
olavloite approved these changes Nov 10, 2023
View reviewed changes

@olavloiteolavloite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with some nits on formatting

Comment threadtests/system/test_dbapi.py Outdated
Comment threadtests/system/test_dbapi.py
Comment threadtests/system/test_dbapi.py Outdated
Comment threadtests/system/test_dbapi.py Outdated
Comment threadtests/system/test_dbapi.py
Comment threadtests/system/test_dbapi.py Outdated
@olavloite
olavloite merged commit 07fbc45 into googleapis:mainNov 17, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Nov 15, 2023
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@olavloiteolavloiteolavloite approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spannerIssues related to the googleapis/python-spanner API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankiaga@olavloite