Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: Implementation for partitioned query in dbapi - #1067

Merged
ankiaga merged 7 commits into
googleapis:mainfrom
ankiaga:partition
Jan 10, 2024
Merged

feat: Implementation for partitioned query in dbapi#1067
ankiaga merged 7 commits into
googleapis:mainfrom
ankiaga:partition

Conversation

@ankiaga

@ankiagaankiaga commented Jan 2, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@ankiaga
ankiaga requested review from a teamJanuary 2, 2024 13:01
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Jan 2, 2024
@ankiaga
ankiaga requested a review from olavloiteJanuary 2, 2024 13:02
olavloite
olavloite reviewed Jan 2, 2024
View reviewed changes

@olavloiteolavloite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally good to me. I think we need some more tests that cover the un-happy path (e.g. what happens if you try to use this in a read/write transaction?)

Comment threadgoogle/cloud/spanner_dbapi/parsed_statement.py Outdated
Comment threadgoogle/cloud/spanner_dbapi/partition_helper.py
Comment threadgoogle/cloud/spanner_dbapi/partition_helper.py Outdated
@ankiaga
ankiaga requested a review from aseeringJanuary 3, 2024 07:21
olavloite
olavloite approved these changes Jan 9, 2024
View reviewed changes
Comment threadgoogle/cloud/spanner_dbapi/client_side_statement_executor.py
Comment threadgoogle/cloud/spanner_dbapi/client_side_statement_executor.py
Comment threadgoogle/cloud/spanner_dbapi/client_side_statement_executor.py
Comment threadtests/system/test_dbapi.py Outdated
Comment threadtests/system/test_dbapi.py Outdated
Comment threadtests/system/test_dbapi.py Outdated
Comment threadtests/system/test_dbapi.py Outdated
@ankiaga
ankiaga merged commit 63daa8a into googleapis:mainJan 10, 2024
@release-pleaserelease-pleaseBot mentioned this pull request Jan 10, 2024
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aseeringaseeringAwaiting requested review from aseering
@manu2manu2Awaiting requested review from manu2
@pratickchokhanipratickchokhaniAwaiting requested review from pratickchokhani
1 more reviewer
@olavloiteolavloiteolavloite approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spannerIssues related to the googleapis/python-spanner API.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankiaga@olavloite