Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

fix: Dates before 1000AD should use 4-digit years - #1132

Merged
surbhigarg92 merged 1 commit into
googleapis:mainfrom
c2nes:pre_1000ad_timestamps
Apr 17, 2024
Merged

fix: Dates before 1000AD should use 4-digit years#1132
surbhigarg92 merged 1 commit into
googleapis:mainfrom
c2nes:pre_1000ad_timestamps

Conversation

@c2nes

Copy link
Copy Markdown
Contributor

This is required for compliance with RFC3339/ISO8401 and timestamps which do not comply will be rejected by Spanner.

Fixes#1131

@c2nes
c2nes requested review from a teamApril 16, 2024 15:59
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Apr 16, 2024
This is required for compliance with RFC3339/ISO8401 and timestamps
which do not comply will be rejected by Spanner.
Fixesgoogleapis#1131
@c2nes
c2nesforce-pushed the pre_1000ad_timestamps branch from 1f7c19b to ea27e1eCompareApril 16, 2024 17:06
@c2nesc2nes changed the title Ensure timestamps before 1000AD use 4-digit yearsfix: Dates before 1000AD should use 4-digit yearsApr 16, 2024
@surbhigarg92surbhigarg92 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 17, 2024
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 17, 2024
@surbhigarg92
surbhigarg92 merged commit 0ef6565 into googleapis:mainApr 17, 2024
@release-pleaserelease-pleaseBot mentioned this pull request Apr 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spannerIssues related to the googleapis/python-spanner API.size: mPull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timestamps before 1000AD rejected in mutation API

3 participants

@c2nes@surbhigarg92@yoshi-kokoro