Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: metricsTracer implementation - #1291

Merged
rahul2393 merged 1 commit into
googleapis:mainfrom
lszinv:lsz/GSO-36/GAX_changes
Jan 24, 2025
Merged

feat: metricsTracer implementation#1291
rahul2393 merged 1 commit into
googleapis:mainfrom
lszinv:lsz/GSO-36/GAX_changes

Conversation

@lszinv

@lszinvlszinv commented Jan 17, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Changes to add MetricsTracer class to be used by interceptors in Spanner GRPC client.

Changes are mirrored from Python GAX until the GAX changes are merged, per discussion with @rahul2393

@lszinv
lszinv requested review from a teamJanuary 17, 2025 08:36
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Jan 17, 2025
@lszinvlszinv closed this Jan 17, 2025
@lszinvlszinv reopened this Jan 17, 2025
@lszinv
lszinvforce-pushed the lsz/GSO-36/GAX_changes branch from fd1d069 to 5002654CompareJanuary 17, 2025 18:54
@product-auto-labelproduct-auto-labelBot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 18, 2025
@rahul2393rahul2393 changed the title Feat: MetricsTracer implementationfeat: MetricsTracer implementationJan 22, 2025
@rahul2393rahul2393 changed the title feat: MetricsTracer implementationfeat: metricsTracer implementationJan 22, 2025
@rahul2393rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2025
@rahul2393

rahul2393 commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

@lszinv There are lint failures

would reformat /tmpfs/src/github/python-spanner/google/cloud/spanner_v1/metrics/metrics_tracer.py
would reformat /tmpfs/src/github/python-spanner/tests/unit/test_metrics_tracer.py
Oh no! 💥 💔 💥
2 files would be reformatted, 174 files would be left unchanged.
nox > Command black --check docs google tests noxfile.py setup.py failed with exit code 1
nox > Session lint failed.

@lszinv
lszinvforce-pushed the lsz/GSO-36/GAX_changes branch from 7373f33 to c21e2d1CompareJanuary 22, 2025 15:16
@rahul2393rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2025
@rahul2393
rahul2393 merged commit 8fbde6b into googleapis:mainJan 24, 2025
@release-pleaserelease-pleaseBot mentioned this pull request Jan 24, 2025
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@rahul2393rahul2393rahul2393 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@bhatt4982bhatt4982

Labels

api: spannerIssues related to the googleapis/python-spanner API.size: xlPull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lszinv@rahul2393@yoshi-kokoro@bhatt4982