Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

fix: configure keepAlive time for gRPC TCP connections - #1448

Merged
rahul2393 merged 9 commits into
mainfrom
set_default_keepalive_time
Oct 28, 2025
Merged

fix: configure keepAlive time for gRPC TCP connections#1448
rahul2393 merged 9 commits into
mainfrom
set_default_keepalive_time

Conversation

@rahul2393

@rahul2393rahul2393 commented Oct 27, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Issue: b/447183913, b/454523963

NodeJS PR: http://github.com/googleapis/nodejs-spanner/pull/2445
Go PR: googleapis/google-cloud-go#13216

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rahul2393
rahul2393 requested review from a teamOctober 27, 2025 06:16
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/python-spanner API. labels Oct 27, 2025
@surbhigarg92surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2025
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2025
@rahul2393

rahul2393 commented Oct 27, 2025

Copy link
Copy Markdown
ContributorAuthor

@parthea can you please help review these changes, is it ok to commit these in autogenerated files will these changes persist if any changes come from owlbot in future?

sakthivelmanii
sakthivelmanii previously approved these changes Oct 27, 2025
View reviewed changes
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 27, 2025
surbhigarg92
surbhigarg92 previously approved these changes Oct 28, 2025
View reviewed changes
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 28, 2025
@rahul2393
rahul2393 merged commit efb2833 into mainOct 28, 2025
23 checks passed
@rahul2393
rahul2393 deleted the set_default_keepalive_time branch October 28, 2025 17:24
@release-pleaserelease-pleaseBot mentioned this pull request Oct 28, 2025
Closed
@ohmayrohmayr mentioned this pull request Nov 18, 2025
Closed
@rahul2393rahul2393 mentioned this pull request Dec 10, 2025
Merged
gcf-merge-on-greenBot pushed a commit that referenced this pull request Dec 10, 2025
@rahul2393
chore: librarian release pull request: 20251210T220651Z (#1462)
24394d6
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.
Librarian Version: v1.0.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91
<details><summary>google-cloud-spanner: 3.60.0</summary>
## [3.60.0](https://togithub.com/googleapis/python-spanner/compare/v3.59.0...v3.60.0) (2025-12-10)
### Features
* make built-in metrics enabled by default (#1459) ([64aebe7](https://togithub.com/googleapis/python-spanner/commit/64aebe7e))
* Exposing AutoscalingConfig in InstancePartition ([8b6f154](https://togithub.com/googleapis/python-spanner/commit/8b6f1540))
* add support for experimental host (#1452) ([9535e5e](https://togithub.com/googleapis/python-spanner/commit/9535e5e0))
* enable OpenTelemetry metrics and tracing by default (#1410) ([bb5095d](https://togithub.com/googleapis/python-spanner/commit/bb5095df))
* add cloud.region, request_tag and transaction_tag in span attributes (#1449) ([d37fb80](https://togithub.com/googleapis/python-spanner/commit/d37fb80a))
* Add QueryAdvisorResult for query plan (PiperOrigin-RevId: 832425466) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe))
* Add Send and Ack mutations for Queues (PiperOrigin-RevId: 832425466) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe))
* Add Spanner location API (#1457) (PiperOrigin-RevId: 833474957) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe))
### Bug Fixes
* Deprecate credentials_file argument ([8b6f154](https://togithub.com/googleapis/python-spanner/commit/8b6f1540))
* configure keepAlive time for gRPC TCP connections (#1448) ([efb2833](https://togithub.com/googleapis/python-spanner/commit/efb2833e))
* Provide Spanner Option to disable metrics (#1460) ([f1ebc43](https://togithub.com/googleapis/python-spanner/commit/f1ebc43b))
### Documentation
* Update description for the BatchCreateSessionsRequest and Session (PiperOrigin-RevId: 832425466) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe))
* Update description for the IsolationLevel (PiperOrigin-RevId: 832425466) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe))
</details>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@partheapartheaparthea approved these changes
@surbhigarg92surbhigarg92surbhigarg92 left review comments
@sakthivelmaniisakthivelmaniisakthivelmanii left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@harshachintaharshachinta

Labels

api: spannerIssues related to the googleapis/python-spanner API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rahul2393@parthea@surbhigarg92@sakthivelmanii@harshachinta