Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: support JSON object consisting of an array. - #782

Merged
gcf-merge-on-green[bot] merged 4 commits into
googleapis:mainfrom
MaxxleLLC:json_array
Aug 17, 2022
Merged

feat: support JSON object consisting of an array.#782
gcf-merge-on-green[bot] merged 4 commits into
googleapis:mainfrom
MaxxleLLC:json_array

Conversation

@IlyaFaer

@IlyaFaerIlyaFaer commented Aug 12, 2022

Copy link
Copy Markdown

No description provided.

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Aug 12, 2022
@IlyaFaer
IlyaFaer marked this pull request as ready for review August 12, 2022 09:43
@IlyaFaer
IlyaFaer requested review from a teamAugust 12, 2022 09:43
@IlyaFaer

IlyaFaer commented Aug 12, 2022

Copy link
Copy Markdown
Author

@asthamohta, okay, JSON-array seems to be working fine with these changes.

@asthamohta

asthamohta commented Aug 16, 2022

Copy link
Copy Markdown
Contributor

Hi Ilya, can you also add a test case in system/test_session_api.py
https://github.com/googleapis/python-spanner/blob/main/tests/system/test_session_api.py#L142
We can add another json value in the array and check if it is fetched correctly:
[
{"name": "room 1", "open": True},
{"name": "room 2", "open": False},
]

@asthamohtaasthamohta linked an issue Aug 16, 2022 that may be closed by this pull request
Issue in the Spanner Python client when an array value is present at the top-level of a JSON column #716
Closed
@asthamohtaasthamohta mentioned this pull request Aug 16, 2022
Closed
@asthamohtaasthamohta added the automerge Merge the pull request once unit tests and other checks pass. label Aug 17, 2022
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 92a3169 into googleapis:mainAug 17, 2022
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 17, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Aug 17, 2022
Merged
@waiho-gumloopwaiho-gumloop mentioned this pull request Feb 27, 2026
Closed
@waiho-gumloopwaiho-gumloop mentioned this pull request Apr 1, 2026
Open
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@asthamohtaasthamohtaasthamohta approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spannerIssues related to the googleapis/python-spanner API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue in the Spanner Python client when an array value is present at the top-level of a JSON column

3 participants

@IlyaFaer@asthamohta@parthea