fix(bucket): Move blob fails when the new blob name contains characters that need to be url encoded (#1605)

fix(bucket): url encode new_name parameter in move_blob()
The move_blob() method was not URL encoding the new_name parameter
before passing it to the API call, unlike how the blob encodes its own
path. This caused failures when moving blobs to paths with special
characters.
Added URL encoding for new_name to match the blob path encoding, as
both names must fit in the API URL format:
"{blob_path}/moveTo/o/{new_name}"
Here's an example of what fails:
```python
from google.cloud import storage
gcs = storage.Client()
bucket = gcs.bucket("")
blob = bucket.get_blob("test/blob.csv")
bucket.move_blob(
blob, new_name="test/blob2.csv"
)
```
Fixes#1523
---------
Co-authored-by: Chandra Shekhar Sirimala <chandrasiri@google.com>

Author: rcleveng

google/cloud/storage/bucket.py

@@ -41,6 +41,7 @@
 fromgoogle.cloud.storage._opentelemetry_tracingimportcreate_trace_span
 fromgoogle.cloud.storage.aclimportBucketACL
 fromgoogle.cloud.storage.aclimportDefaultObjectACL
+fromgoogle.cloud.storage.blobimport_quote
 fromgoogle.cloud.storage.blobimportBlob
 fromgoogle.cloud.storage.constantsimport_DEFAULT_TIMEOUT
 fromgoogle.cloud.storage.constantsimportARCHIVE_STORAGE_CLASS
@@ -2360,7 +2361,10 @@ def move_blob(
  )
 
 new_blob=Blob(bucket=self, name=new_name)
-api_path=blob.path+"/moveTo/o/"+new_blob.name
+api_path="{blob_path}/moveTo/o/{new_name}".format(
+blob_path=blob.path, new_name=_quote(new_blob.name)
+ )
+
 move_result=client._post_resource(
 api_path,
 None,

tests/unit/test_bucket.py

@@ -18,6 +18,7 @@
 importmock
 importpytest
 
+fromgoogle.cloud.storage.blobimport_quote
 fromgoogle.cloud.storage.retryimportDEFAULT_RETRY
 fromgoogle.cloud.storage.retryimportDEFAULT_RETRY_IF_ETAG_IN_JSON
 fromgoogle.cloud.storage.retryimportDEFAULT_RETRY_IF_GENERATION_SPECIFIED
@@ -2320,6 +2321,37 @@ def test_move_blob_w_no_retry_timeout_and_generation_match(self):
 _target_object=new_blob,
  )
 
+deftest_move_blob_needs_url_encoding(self):
+source_name="source"
+blob_name="blob-name"
+new_name="new/name"
+api_response= {}
+client=mock.Mock(spec=["_post_resource"])
+client._post_resource.return_value=api_response
+source=self._make_one(client=client, name=source_name)
+blob=self._make_blob(source_name, blob_name)
+
+new_blob=source.move_blob(
+blob, new_name, if_generation_match=0, retry=None, timeout=30
+ )
+
+self.assertIs(new_blob.bucket, source)
+self.assertEqual(new_blob.name, new_name)
+
+expected_path="/b/{}/o/{}/moveTo/o/{}".format(
+source_name, blob_name, _quote(new_name)
+ )
+expected_data=None
+expected_query_params= {"ifGenerationMatch": 0}
+client._post_resource.assert_called_once_with(
+expected_path,
+expected_data,
+query_params=expected_query_params,
+timeout=30,
+retry=None,
+_target_object=new_blob,
+ ) 
+
 deftest_move_blob_w_user_project(self):
 source_name="source"
 blob_name="blob-name"