Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: add offset and includeTrailingPrefix options to list_blobs - #125

Merged
frankyn merged 4 commits into
masterfrom
new-list-flags
May 5, 2020
Merged

feat: add offset and includeTrailingPrefix options to list_blobs#125
frankyn merged 4 commits into
masterfrom
new-list-flags

Conversation

@andrewsg

Copy link
Copy Markdown
Contributor

No description provided.

@andrewsg
andrewsg requested review from crwilcox and frankynMay 1, 2020 21:08
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2020

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrewsg, added two nits

Comment threadtests/system/test_system.py Outdated
blobs = list(page)
self.assertEqual([blob.name for blob in blobs], ["file01.txt", "parent/"])
self.assertIsNone(iterator.next_page_token)
self.assertEqual(iterator.prefixes, set(["parent/"]))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this request different when include_trailinig_delimitier=False? I don't see the difference between the system test in this case.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is that this is the only name that includes parent/ in self.assertEqual([blob.name for blob in blobs], ["file01.txt", "parent/"]).

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this for you to resolve if you're satisfied with that explanation

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@frankyn
frankyn merged commit d84c0dd into masterMay 5, 2020
@tseaver
tseaver deleted the new-list-flags branch August 24, 2021 18:08
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…gleapis#125)
* feat: add offset and includeTrailingPrefix options to list_blobs
* lint
* fix comment typo in system tests
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…gleapis#125)
* feat: add offset and includeTrailingPrefix options to list_blobs
* lint
* fix comment typo in system tests
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewsg@frankyn@googlebot