Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: Changed name of methods Blob.from_string() and Bucket.from_string() to from_uri() - #1335

Merged
andrewsg merged 1 commit into
3.0-develfrom
from_uri
Oct 7, 2024
Merged

fix: Changed name of methods Blob.from_string() and Bucket.from_string() to from_uri()#1335
andrewsg merged 1 commit into
3.0-develfrom
from_uri

Conversation

@holtskinner

@holtskinnerholtskinner commented Aug 6, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Other methods use "string" to refer to the actual content of the Blob, not the uri. The updated method name is more intuitive for developers.
  • Marked from_string() as deprecated and mapped functionality to from_uri().

Original reasoning for from_string() naming in #7693

@holtskinner
holtskinner requested review from a teamAugust 6, 2024 14:48
@product-auto-labelproduct-auto-labelBot added the size: m Pull request size is medium. label Aug 6, 2024
@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label Aug 6, 2024
@holtskinnerholtskinner added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2024
@holtskinner
holtskinner changed the base branch from main to 3.0-develOctober 4, 2024 17:19
@holtskinner
holtskinner requested a review from a team as a code ownerOctober 4, 2024 17:19
@holtskinner
holtskinner requested review from glasnt and removed request for a teamOctober 4, 2024 17:19
@holtskinner
holtskinner changed the base branch from 3.0-devel to mainOctober 4, 2024 17:20
@holtskinner
holtskinner changed the base branch from main to 3.0-develOctober 4, 2024 17:26
@product-auto-labelproduct-auto-labelBot added size: u Pull request is empty. and removed size: m Pull request size is medium. labels Oct 4, 2024
@holtskinnerholtskinner reopened this Oct 4, 2024
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. and removed size: u Pull request is empty. labels Oct 4, 2024
@holtskinnerholtskinner added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 4, 2024
@andrewsg

andrewsg commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

Thank you!

@andrewsg
andrewsg merged commit ae917ee into 3.0-develOct 7, 2024
@andrewsg
andrewsg deleted the from_uri branch October 7, 2024 15:47
andrewsg pushed a commit that referenced this pull request Dec 5, 2024
@holtskinner@andrewsg
fix: Changed name of methods Blob.from_string() and `Bucket.from_st…
1b98fb2
…ring()` to `from_uri()` (#1335)
andrewsg pushed a commit that referenced this pull request Dec 10, 2024
@holtskinner@andrewsg
fix: Changed name of methods Blob.from_string() and `Bucket.from_st…
a55f25d
…ring()` to `from_uri()` (#1335)
andrewsg pushed a commit that referenced this pull request Dec 11, 2024
@holtskinner@andrewsg
fix: Changed name of methods Blob.from_string() and `Bucket.from_st…
58c1d03
…ring()` to `from_uri()` (#1335)
@release-pleaserelease-pleaseBot mentioned this pull request Dec 11, 2024
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@glasntglasntAwaiting requested review from glasntglasnt was automatically assigned from googleapis/python-samples-reviewers
1 more reviewer
@andrewsgandrewsgandrewsg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@andrewsgandrewsg

Labels

api: storageIssues related to the googleapis/python-storage API.kokoro:runAdd this label to force Kokoro to re-run the tests.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@holtskinner@andrewsg@yoshi-kokoro