Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: add helper for bucket bound hostname URLs - #137

Merged
gcf-merge-on-green[bot] merged 15 commits into
googleapis:masterfrom
MaxxleLLC:bucker_bound_hostname_helper
May 28, 2020
Merged

feat: add helper for bucket bound hostname URLs#137
gcf-merge-on-green[bot] merged 15 commits into
googleapis:masterfrom
MaxxleLLC:bucker_bound_hostname_helper

Conversation

@IlyaFaer

@IlyaFaerIlyaFaer commented May 7, 2020

Copy link
Copy Markdown

Closes#121

@IlyaFaerIlyaFaer added api: storage Issues related to the googleapis/python-storage API. type: cleanup An internal cleanup or hygiene concern. labels May 7, 2020
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2020
@IlyaFaerIlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2020
IlyaFaer
IlyaFaer commented May 7, 2020
View reviewed changes
Comment threadgoogle/cloud/storage/_helpers.py Outdated
@IlyaFaer
IlyaFaer marked this pull request as ready for review May 7, 2020 12:27
frankyn
frankyn suggested changes May 13, 2020
View reviewed changes

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this change @IlyaFaer, left a question.

Comment threadgoogle/cloud/storage/_helpers.py Outdated
frankyn
frankyn suggested changes May 22, 2020
View reviewed changes
Comment threadgoogle/cloud/storage/_helpers.py Outdated
@frankynfrankyn added the automerge Merge the pull request once unit tests and other checks pass. label May 27, 2020
@gcf-merge-on-green

gcf-merge-on-greenBot commented May 27, 2020

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green

gcf-merge-on-greenBot commented May 27, 2020

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green

gcf-merge-on-greenBot commented May 28, 2020

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@frankynfrankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2020
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit b26f9fa into googleapis:masterMay 28, 2020
@IlyaFaer
IlyaFaer deleted the bucker_bound_hostname_helper branch May 28, 2020 07:30
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Gurov Ilya@cojenco
feat: add helper for bucket bound hostname URLs (googleapis#137)
53e826d
Closesgoogleapis#121
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Gurov Ilya@cojenco
feat: add helper for bucket bound hostname URLs (googleapis#137)
aeb2fa0
Closesgoogleapis#121
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewsgandrewsgAwaiting requested review from andrewsg
@crwilcoxcrwilcoxAwaiting requested review from crwilcox
1 more reviewer
@frankynfrankynfrankyn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the googleapis/python-storage API.automergeMerge the pull request once unit tests and other checks pass.cla: yesThis human has signed the Contributor License Agreement.type: cleanupAn internal cleanup or hygiene concern.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move bucket_bound_hostname code into helper

4 participants

@IlyaFaer@frankyn@googlebot@yoshi-kokoro