Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: Segmentation fault in tink while writing data - #1490

Merged
Pulkit0110 merged 3 commits into
googleapis:mainfrom
Pulkit0110:integer-vulnerability-fix
Jun 13, 2025
Merged

fix: Segmentation fault in tink while writing data#1490
Pulkit0110 merged 3 commits into
googleapis:mainfrom
Pulkit0110:integer-vulnerability-fix

Conversation

@Pulkit0110

@Pulkit0110Pulkit0110 commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Tink doesn't properly validate the value returned by the python output stream's write method. Usually, this value should be smaller than the size of the data. But the write method returns the complete size of the object instead of the size of bytes of the chunk written.

@Pulkit0110
Pulkit0110 requested review from a teamJune 5, 2025 06:38
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. labels Jun 5, 2025
@Pulkit0110Pulkit0110 mentioned this pull request Jun 6, 2025
Closed
@Pulkit0110Pulkit0110 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2025
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2025
@chandra-siri

chandra-siri commented Jun 6, 2025

Copy link
Copy Markdown
Collaborator

Please add unit tests as per cl/766131162

@Pulkit0110

Pulkit0110 commented Jun 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Done

@Pulkit0110Pulkit0110 reopened this Jun 9, 2025
vasporig
vasporig reviewed Jun 10, 2025
View reviewed changes
Comment threadtests/unit/test_fileio.py
vasporig
vasporig reviewed Jun 10, 2025
View reviewed changes

@vasporigvasporig left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please add one more test

@ddelgrosso1ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 13, 2025
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 13, 2025
@Pulkit0110
Pulkit0110 merged commit 2a46c0b into googleapis:mainJun 13, 2025
@release-pleaserelease-pleaseBot mentioned this pull request Jun 7, 2025
Merged
@Pulkit0110
Pulkit0110 deleted the integer-vulnerability-fix branch January 2, 2026 11:06
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@vasporigvasporigvasporig approved these changes
@chandra-sirichandra-sirichandra-siri approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@chandra-sirichandra-siri

Labels

api: storageIssues related to the googleapis/python-storage API.size: xsPull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Pulkit0110@chandra-siri@vasporig@ddelgrosso1