Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: extract hashes correctly during download - #238

Merged
tseaver merged 8 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_237
Aug 14, 2020
Merged

fix: extract hashes correctly during download#238
tseaver merged 8 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_237

Conversation

@HemangChothani

@HemangChothaniHemangChothani commented Aug 11, 2020

Copy link
Copy Markdown
Contributor

Fixes#237 🦕

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2020
frankyn
frankyn previously requested changes Aug 11, 2020
View reviewed changes
Comment threadgoogle/cloud/storage/blob.py Outdated
Comment threadtests/unit/test_blob.py
@william-silversmithwilliam-silversmith mentioned this pull request Aug 12, 2020
Closed
tseaver
tseaver suggested changes Aug 13, 2020
View reviewed changes
Comment threadgoogle/cloud/storage/blob.py Outdated
@tseavertseaver changed the title fix: multiple upload and downloadfix: extract hashes correctly during downloadAug 13, 2020
@tseavertseaver added the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2020
@gcf-merge-on-green

gcf-merge-on-greenBot commented Aug 13, 2020

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green

gcf-merge-on-greenBot commented Aug 14, 2020

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 14, 2020
@HemangChothaniHemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2020
@tseaver
tseaver merged commit 23cfb65 into googleapis:masterAug 14, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani@tseaver@cojenco
fix: extract hashes correctly during download (googleapis#238)
3c90a87
Co-authored-by: Tres Seaver <tseaver@palladion.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani@tseaver@cojenco
fix: extract hashes correctly during download (googleapis#238)
33f699e
Co-authored-by: Tres Seaver <tseaver@palladion.com>
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@tseavertseavertseaver approved these changes
@frankynfrankynfrankyn left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple upload and downloads fail

4 participants

@HemangChothani@tseaver@frankyn@yoshi-kokoro