feat: public access prevention by shaffeeullah · Pull Request #304 · googleapis/python-storage

shaffeeullah · 2020-11-09T22:40:01Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes#312 🦕

tritone

Generally looks good-- my biggest question is whether we should use some kind of enum or constant for the values.

tseaver · 2020-11-11T19:58:19Z

The systest failures seem to indicate that the feature is not working as expected. Do we need to get the CI project added to a whitelist?

shaffeeullah · 2020-11-11T20:12:33Z

The systest failures seem to indicate that the feature is not working as expected. Do we need to get the CI project added to a whitelist?

The backend feature still has some bugs that are being resolved. The current failure is expected at this time.

google-cla · 2020-11-16T20:17:52Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-11-16T20:17:52Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-11-16T20:25:52Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-11-16T23:03:00Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-12-22T21:31:01Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-12-23T17:55:32Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

shaffeeullah · 2020-12-23T18:17:54Z

Hi @tseaver , can you please sign the CLA? See #304 (comment)

shaffeeullah · 2021-01-12T21:33:42Z

Hi @tseaver , can you please sign the CLA? See #304 (comment)

@tseaver friendly bump

googlebot · 2021-01-12T22:16:04Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

andrewsg · 2021-01-12T22:17:36Z

Tres has signed the CLA and submitted other PRs with the same email address without issue, so I don't know why googlebot is complaining here.

andrewsg · 2021-01-12T22:22:42Z

@shaffeeullah This seems to be an issue with Github adding Tres to the contributor list automatically, with different user details than he normally uses based on the git config in his actual computer.

Tres definitely is a CLA signer. I conferred with Frank and he suggested you rebase to remove Tres from the contributor list and force-push. Please message me on chat if you need help wrangling git here. And make a backup of your branch just in case.

tritone

One minor docs comment, otherwise looks good!

google-cla · 2021-06-08T22:58:06Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-08T22:58:06Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

shaffeeullah · 2021-06-11T19:59:55Z

Public access prevention rollout has been delayed due to a bug surfaced during Googler preview. I will keep this PR updated as I learn new release timeline details.

shaffeeullah · 2021-06-28T17:51:01Z

@andrewsg This feature can now be merged and released. Are you able to help me with this?

tseaver · 2021-06-30T14:42:32Z

@shaffeeullah I can help fix the merge, since my PR refactoring the system tests is what broke your new ones.

google-cla · 2021-06-30T14:55:43Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

tseaver · 2021-06-30T14:56:05Z

@googlebot I consent.

google-cla · 2021-06-30T14:56:27Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-30T14:57:49Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

shaffeeullah · 2021-06-30T14:58:22Z

Thanks, @tseaver !! @andrewsg @tseaver If the tests pass, would it be possible to release this today?

tseaver · 2021-06-30T15:01:53Z

@shaffeeullah Yes, we should be able to make a release. @cojenco, are any of your open PRs at a state where they should be merged before a release?

cojenco · 2021-06-30T16:05:55Z

Thanks @tseaver and @shaffeeullah! I'll be merging #480 shortly and trying to squeeze in #484 this morning as well for the release.

tseaver · 2021-06-30T17:16:34Z

@shaffeeullah Release is in progress: PR #485

…eapis#304)

google-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2020

shaffeeullah requested a review from tritone November 9, 2020 22:40

product-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label Nov 9, 2020

tritone reviewed Nov 10, 2020
View reviewed changes

Comment threadgoogle/cloud/storage/bucket.py Outdated
Comment threadgoogle/cloud/storage/bucket.py Outdated
Comment threadtests/system/test_system.py Outdated
Comment threadtests/system/test_system.py Outdated

tritone requested a review from andrewsg November 10, 2020 19:28

tritone reviewed Nov 11, 2020
View reviewed changes

Comment threadgoogle/cloud/storage/bucket.py Outdated

shaffeeullah requested a review from tritone November 11, 2020 19:06

tseaver suggested changes Nov 11, 2020
View reviewed changes

Comment threadgoogle/cloud/storage/bucket.py Outdated
Comment threadgoogle/cloud/storage/bucket.py
Comment threadgoogle/cloud/storage/bucket.py
Comment threadtests/system/test_system.py Outdated

shaffeeullah requested a review from tseaver November 16, 2020 17:21

tseaver reviewed Nov 16, 2020
View reviewed changes

Comment threadgoogle/cloud/storage/bucket.py Outdated
Comment threadgoogle/cloud/storage/bucket.py Outdated
Comment threadgoogle/cloud/storage/bucket.py
Comment threadgoogle/cloud/storage/bucket.py

google-claBot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 16, 2020

shaffeeullah requested a review from tseaver November 16, 2020 20:26

shaffeeullah added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 23, 2020

shaffeeullah marked this pull request as ready for review December 23, 2020 18:16

shaffeeullah requested a review from a teamDecember 23, 2020 18:16

tritone approved these changes Jan 21, 2021
View reviewed changes

Comment threadgoogle/cloud/storage/bucket.py

docs: include link to the GCS PAP docs in docstring
4264534

tseaver approved these changes Jun 8, 2021
View reviewed changes

tritone removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Jun 29, 2021

Merge branch 'master' into publicaccessprevention
f0e6117

google-claBot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 30, 2021

google-claBot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 30, 2021

tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2021

chore: blacken
157f25e

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2021

tseaver merged commit e3e57a9 into googleapis:masterJun 30, 2021

shaffeeullah deleted the publicaccessprevention branch June 30, 2021 15:26

cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
feat: add public access prevention to bucket IAM configuration (googl…
62b0f9e
…eapis#304)

cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
feat: add public access prevention to bucket IAM configuration (googl…
71cb54a
…eapis#304)

release-pleaseBot mentioned this pull request Jan 12, 2022
chore(main): release 3.0.0 #688
Closed

Uh oh!

Conversation

shaffeeullah commented Nov 9, 2020• edited by tseaver Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tritone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tseaver commented Nov 11, 2020

Uh oh!

shaffeeullah commented Nov 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-claBot commented Nov 16, 2020

Uh oh!

google-claBot commented Nov 16, 2020

Uh oh!

google-claBot commented Nov 16, 2020

Uh oh!

google-claBot commented Nov 16, 2020

Uh oh!

google-claBot commented Dec 22, 2020

Uh oh!

google-claBot commented Dec 23, 2020

Uh oh!

shaffeeullah commented Dec 23, 2020

Uh oh!

shaffeeullah commented Jan 12, 2021

Uh oh!

googlebot commented Jan 12, 2021

Uh oh!

andrewsg commented Jan 12, 2021

Uh oh!

andrewsg commented Jan 12, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tritone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

google-claBot commented Jun 8, 2021

Uh oh!

google-claBot commented Jun 8, 2021

Uh oh!

shaffeeullah commented Jun 11, 2021

Uh oh!

shaffeeullah commented Jun 28, 2021

Uh oh!

tseaver commented Jun 30, 2021

Uh oh!

google-claBot commented Jun 30, 2021

Uh oh!

tseaver commented Jun 30, 2021

Uh oh!

google-claBot commented Jun 30, 2021

Uh oh!

google-claBot commented Jun 30, 2021

Uh oh!

shaffeeullah commented Jun 30, 2021

Uh oh!

tseaver commented Jun 30, 2021

Uh oh!

cojenco commented Jun 30, 2021

Uh oh!

tseaver commented Jun 30, 2021

Uh oh!

Reviewers

Assignees

shaffeeullah commented Nov 9, 2020•
edited by tseaver
Loading

andrewsg commented Jan 12, 2021•
edited
Loading