fix: revise blob.compose query parameters `if_generation_match` by cojenco · Pull Request #454 · googleapis/python-storage

cojenco · 2021-06-05T01:19:48Z

This changes if_generation_match, if_metageneration_match, if_source_generation_match for blob.compose() to fit API behavior

Add pending deprecation warning in cases where if_generation_match and if_metageneration_match is passed in as a list of long. Add conditional handling for backwards compatibility.
Update if_generation_match to be correctly included within the API request query parameters if it is type long. This makes the operation conditional on whether the composed object's current generation matches the given value.
Add if_source_generation_match as an optional parameter that serves as sourceObjects preconditions. This is sent with the API request body. When provided, the composition only performs if the generation of the source object that would be used matches this value.
Revise docstring, example and tests

Fixes#453🦕

tseaver · 2021-06-08T17:07:23Z

@cojenco I will merge / repair the tests broken by my PRs this week.

google-cla · 2021-06-08T17:23:01Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

tseaver · 2021-06-08T17:23:24Z

@googlebot I consent.

tseaver · 2021-06-08T17:45:13Z

@cojenco I put back the do not merge label to allow us to consider whether this might be a breaking change.

cojenco · 2021-06-08T19:36:03Z

Got it, thanks @tseaver!

cojenco · 2021-06-08T21:43:12Z

This currently will introduce a breaking change. Revising PR for backwards compatibility.

snippet-bot · 2021-06-10T21:24:51Z

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

cojenco · 2021-06-10T22:59:43Z

Updated PR to handle backwards compatibility. Ready for review:)

andrewsg · 2021-06-11T20:11:53Z

+ Setting to 0 makes the operation succeed only if there are no live
+ versions of the object.
+
+ If a list of long is passed in, makes the operation conditional on whether the


I would recommend phrasing this something like:
"Note: In a previous version, this argument worked identically to the if_source_generation_match argument. For backwards-compatibility reasons, if a list is passed in, this argument will behave like if_source_generation_match and also issue a DeprecationWarning."

Done. I like this phrasing a lot, thanks!

andrewsg

Thanks!

…leapis#454) * revise blob.compose logic to match API usage * update tests * update system test * address comments * 🦉 Updates from OwlBot * revise logic for backwards compatibility * add tests * revise docstring * fix test * revise to DeprecationWarning * address comments and revise docstrings Co-authored-by: Tres Seaver <tseaver@palladion.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

cojenco added 3 commits June 4, 2021 16:46

revise blob.compose logic to match API usage
a1a66c3

update tests
bd7407a

update system test
a896eff

cojenco requested review from a teamJune 5, 2021 01:19

product-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label Jun 5, 2021

google-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2021

tseaver suggested changes Jun 7, 2021
View reviewed changes

Comment threadgoogle/cloud/storage/blob.py Outdated
Comment threadgoogle/cloud/storage/blob.py
Comment threadgoogle/cloud/storage/blob.py
Comment threadgoogle/cloud/storage/blob.py Outdated
Comment threadgoogle/cloud/storage/blob.py Outdated

cojenco added 2 commits June 7, 2021 10:24

Merge branch 'master' into obj-compose-retry
5dec505

address comments
b4363af

tseaver approved these changes Jun 7, 2021
View reviewed changes

cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 7, 2021

Merge branch 'master' into obj-compose-retry
87a7411

google-claBot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 8, 2021

google-claBot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 8, 2021

🦉 Updates from OwlBot
13e221f

tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 8, 2021

tseaver mentioned this pull request Jun 8, 2021
chore: release 1.38.1 #438
Closed

tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 8, 2021

Merge branch 'master' into obj-compose-retry
1c1d70d

cojenco requested a review from andrewsg June 8, 2021 19:42

revise logic for backwards compatibility
42be461

cojenco added 3 commits June 8, 2021 17:12

add tests
b94f05c

revise docstring
b6ce5ef

Merge main branch
8526054

fix test
3958562

tseaver suggested changes Jun 11, 2021
View reviewed changes

Comment threadgoogle/cloud/storage/blob.py
Comment threadgoogle/cloud/storage/blob.py
Comment threadgoogle/cloud/storage/blob.py
Comment threadtests/system/test_system.py

revise to DeprecationWarning
941da79

cojenco commented Jun 11, 2021
View reviewed changes

Comment threadtests/system/test_system.py

tseaver mentioned this pull request Jun 11, 2021
docs: streamline docstrings for conditional parmas #464
Merged

andrewsg suggested changes Jun 11, 2021
View reviewed changes

address comments and revise docstrings
23be964

cojenco removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 11, 2021

Merge branch 'master' into obj-compose-retry
e2c051c

tseaver approved these changes Jun 14, 2021
View reviewed changes

cojenco requested a review from andrewsg June 14, 2021 16:10

andrewsg approved these changes Jun 14, 2021
View reviewed changes

cojenco merged commit 70d19e7 into masterJun 14, 2021

cojenco deleted the obj-compose-retry branch June 14, 2021 22:31

release-pleaseBot mentioned this pull request Jan 12, 2022
chore(main): release 3.0.0 #688
Closed

Uh oh!

Conversation

cojenco commented Jun 5, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tseaver commented Jun 8, 2021

Uh oh!

google-claBot commented Jun 8, 2021

Uh oh!

tseaver commented Jun 8, 2021

Uh oh!

tseaver commented Jun 8, 2021

Uh oh!

cojenco commented Jun 8, 2021

Uh oh!

cojenco commented Jun 8, 2021

Uh oh!

snippet-botBot commented Jun 10, 2021

No region tags are edited in this PR.

Uh oh!

cojenco commented Jun 10, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andrewsgJun 11, 2021

Choose a reason for hiding this comment

Uh oh!

cojencoJun 11, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andrewsg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cojenco commented Jun 5, 2021•
edited
Loading