Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat(storage): improve v4 signature query parameters encoding - #48

Merged
crwilcox merged 18 commits into
googleapis:masterfrom
MaxxleLLC:v4_sign_query_params
Mar 7, 2020
Merged

feat(storage): improve v4 signature query parameters encoding#48
crwilcox merged 18 commits into
googleapis:masterfrom
MaxxleLLC:v4_sign_query_params

Conversation

@IlyaFaer

@IlyaFaerIlyaFaer commented Feb 7, 2020

Copy link
Copy Markdown

Closes#9

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 7, 2020
IlyaFaer
IlyaFaer commented Feb 10, 2020
View reviewed changes
Comment threadgoogle/cloud/storage/_signing.py
Comment threadgoogle/cloud/storage/_signing.py
Comment threadtests/unit/test__signing.py
Comment threadgoogle/cloud/storage/_signing.py
@IlyaFaer
IlyaFaer marked this pull request as ready for review February 10, 2020 09:50
@IlyaFaerIlyaFaer added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 10, 2020
@frankyn

frankyn commented Feb 11, 2020

Copy link
Copy Markdown
Contributor

@IlyaFaer this LGTM, but please update relevant conformance tests before merging this code to confirm that it's working as expected.

I updated conformance tests in https://github.com/googleapis/conformance-tests/tree/master/storage/v1

If you have questions PLMK. Specifically for this change you should rely on the following two conformance tests:

  • Query Parameter Encoding
  • Query Parameter Ordering

IlyaFaer pushed a commit to MaxxleLLC/conformance-tests that referenced this pull request Feb 12, 2020
IlyaFaer
change expected result for V4 Signed URL to follow changes made ingo…
9545865
…ogleapis/python-storage#48
@IlyaFaerIlyaFaer mentioned this pull request Feb 12, 2020
Closed
tseaver
tseaver previously requested changes Feb 12, 2020
View reviewed changes
Comment threadgoogle/cloud/storage/_signing.py
Comment threadtests/unit/test__signing.py
Comment threadgoogle/cloud/storage/_signing.py Outdated
@tseaver

tseaver commented Feb 12, 2020

Copy link
Copy Markdown
Contributor

This PR also addresses part of the change for #12.

This was referenced Feb 12, 2020
Closed
Merged
@tseaver

tseaver commented Feb 12, 2020

Copy link
Copy Markdown
Contributor

@frankyn We don't currently do any of the cross-language conformance tests inside python-storage. I just made #57 to track that.

@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2020
@tseavertseaver mentioned this pull request Feb 12, 2020
Closed
@frankyn

frankyn commented Feb 13, 2020

Copy link
Copy Markdown
Contributor

@IlyaFaer please respond to @tseaver's comments before merging

tseaver
tseaver reviewed Feb 13, 2020
View reviewed changes
Comment threadgoogle/cloud/storage/_signing.py Outdated
Comment threadgoogle/cloud/storage/_signing.py
@frankyn

frankyn commented Feb 20, 2020

Copy link
Copy Markdown
Contributor

Friendly ping and pending Kokoro passing.

@frankyn
frankyn requested a review from tseaverFebruary 26, 2020 15:23
@frankyn

frankyn commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

Merging when green.

@frankyn

frankyn commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

Pending approval from @tseaver as there is on-going discussion.

@frankyn

frankyn commented Mar 6, 2020

Copy link
Copy Markdown
Contributor

@tseaver friendly ping

@crwilcox
crwilcox dismissed tseaver’s stale reviewMarch 6, 2020 23:35

Reviewed, attempted to remove coercion, but due to truthiness of bytes and strs in python 2 I am going to approve this.

@crwilcoxcrwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2020
@crwilcoxcrwilcox added the automerge Merge the pull request once unit tests and other checks pass. label Mar 6, 2020
@crwilcox
crwilcox removed the request for review from tseaverMarch 7, 2020 00:21
@crwilcoxcrwilcox mentioned this pull request Mar 7, 2020
Closed
@crwilcox
crwilcox merged commit 8df0b55 into googleapis:masterMar 7, 2020
@IlyaFaer
IlyaFaer deleted the v4_sign_query_params branch April 1, 2020 20:02
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Gurov Ilya@frankyn
@crwilcox@cojenco
feat(storage): improve v4 signature query parameters encoding (google…
5f04e38
…apis#48)
* feat(storage): improve v4 signature query parameters encoding
* add URL encoding test
* add query_parameters arg into conformance tests
* add tests for _quote_param() function
* declare test file encoding
* fix the param type
* add test with bytes
* Update _signing.py
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Christopher Wilcox <crwilcox@google.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Gurov Ilya@frankyn
@crwilcox@cojenco
feat(storage): improve v4 signature query parameters encoding (google…
0f4adf3
…apis#48)
* feat(storage): improve v4 signature query parameters encoding
* add URL encoding test
* add query_parameters arg into conformance tests
* add tests for _quote_param() function
* declare test file encoding
* fix the param type
* add test with bytes
* Update _signing.py
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Christopher Wilcox <crwilcox@google.com>
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@tseavertseavertseaver left review comments
@frankynfrankynfrankyn approved these changes
@crwilcoxcrwilcoxcrwilcox approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automergeMerge the pull request once unit tests and other checks pass.cla: yesThis human has signed the Contributor License Agreement.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Storage] V4 Signature Supplying Additional Query Parameters With GCS Signed URLs

6 participants

@IlyaFaer@frankyn@tseaver@crwilcox@googlebot@yoshi-kokoro