Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
fix: remove trailing commas from error message constants - #505
Merged
Conversation
tseaver
suggested changes
Jul 15, 2021
tseaver
left a comment
Contributor
There was a problem hiding this comment.
Thanks very much for the patch! Can you please also remove the trailing commas for _COMPOSE_IF_GENERATION_LIST_DEPRECATED and _COMPOSE_IF_GENERATION_LIST_AND_IF_SOURCE_GENERATION_ERROR?
The _DOWNLOAD_AS_STRING_DEPRECATED, _COMPOSE_IF_GENERATION_LIST_DEPRECATED and _COMPOSE_IF_GENERATION_LIST_AND_IF_SOURCE_GENERATION_ERROR constants include a dangling comma which make them tuples and not strings. This causes a TypeError as reported in googleapis#501. Closesgoogleapis#501
rjw57
commented
Jul 15, 2021
ContributorAuthor
Done. I should've looked myself for any other offenders(!) |
tseaver
approved these changes
Jul 15, 2021
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
) The _DOWNLOAD_AS_STRING_DEPRECATED constant includes a dangling comma which makes it a tuple and not a string. This causes a TypeError as reported in googleapis#501. Fixesgoogleapis#501
cojenco pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
) The _DOWNLOAD_AS_STRING_DEPRECATED constant includes a dangling comma which makes it a tuple and not a string. This causes a TypeError as reported in googleapis#501. Fixesgoogleapis#501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _DOWNLOAD_AS_STRING_DEPRECATED constant includes a dangling comma
which makes it a tuple and not a string. This causes a TypeError as reported in #501.
Fixes#501