Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: add turbo replication support and samples - #622

Merged
unforced merged 27 commits into
googleapis:mainfrom
unforced:rpo-changes
Jan 18, 2022
Merged

feat: add turbo replication support and samples#622
unforced merged 27 commits into
googleapis:mainfrom
unforced:rpo-changes

Conversation

@unforced

@unforcedunforced commented Oct 13, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#605 and #606

@unforced
unforced requested review from a team and ddelgrosso1October 13, 2021 19:33
@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label Oct 13, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2021
tseaver
tseaver reviewed Oct 13, 2021
View reviewed changes
Comment threadgoogle/cloud/storage/client.py Outdated
@unforcedunforced added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
cojenco
cojenco reviewed Oct 14, 2021
View reviewed changes
Comment threadgoogle/cloud/storage/bucket.py
cojenco
cojenco reviewed Oct 14, 2021
View reviewed changes
Comment threadtests/unit/test_bucket.py
@snippet-bot

snippet-botBot commented Oct 19, 2021•
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@unforcedunforced changed the title feat: add turbo replication supportfeat: add turbo replication support and samplesOct 19, 2021
@product-auto-labelproduct-auto-labelBot added the samples Issues that are directly related to samples. label Oct 20, 2021
cojenco
cojenco reviewed Oct 20, 2021
View reviewed changes
Comment threadsamples/snippets/rpo_test.py Outdated
cojenco
cojenco reviewed Oct 20, 2021
View reviewed changes
Comment threadsamples/snippets/storage_get_rpo.py Outdated
cojenco
cojenco reviewed Oct 20, 2021
View reviewed changes
Comment threadsamples/snippets/storage_set_rpo_async_turbo.py Outdated
cojenco
cojenco approved these changes Oct 20, 2021
View reviewed changes

@cojencocojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! A few nits, otherwise LGTM

@cojencocojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 8, 2021
@ddelgrosso1

ddelgrosso1 commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

This can be merged / released now.

@unforcedunforced removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 12, 2022
@unforced
unforced requested a review from a team as a code ownerJanuary 12, 2022 15:54
@unforced
unforced requested a review from nicainJanuary 12, 2022 15:54
@unforcedunforced added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@dandhleedandhlee added cla: yes This human has signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 12, 2022
dandhlee
dandhlee reviewed Jan 13, 2022
View reviewed changes
Comment threadsamples/snippets/rpo_test.py
@unforcedunforced mentioned this pull request Jan 18, 2022
Closed
@unforced
unforced merged commit 4dafc81 into googleapis:mainJan 18, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Jan 18, 2022
Merged
@cojencocojenco mentioned this pull request Feb 9, 2022
Closed
@release-pleaserelease-pleaseBot mentioned this pull request Aug 10, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicainnicainAwaiting requested review from nicainnicain was automatically assigned from googleapis/python-samples-owners
4 more reviewers
@tseavertseavertseaver left review comments
@cojencocojencocojenco approved these changes
@dandhleedandhleedandhlee left review comments
@ddelgrosso1ddelgrosso1ddelgrosso1 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the googleapis/python-storage API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for turbo replication

6 participants

@unforced@ddelgrosso1@tseaver@cojenco@dandhlee@yoshi-kokoro