Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat!: Remove Python 2 support - #657

Merged
andrewsg merged 13 commits into
mainfrom
python-2-turndown
Jan 12, 2022
Merged

feat!: Remove Python 2 support#657
andrewsg merged 13 commits into
mainfrom
python-2-turndown

Conversation

@andrewsg

@andrewsgandrewsg commented Nov 22, 2021

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: This PR removes Python 2 support in the setup.py metadata, test runner and code itself. This is intended to be released as a major version update. Python 2 users can continue to use the 1.x version of the client library.

@andrewsgandrewsg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 22, 2021
@andrewsg
andrewsg requested review from a team, cojenco, tseaver and unforcedNovember 22, 2021 23:14
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2021
@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label Nov 22, 2021
tseaver
tseaver suggested changes Nov 26, 2021
View reviewed changes
Comment threadgoogle/cloud/storage/_signing.py
Comment threadgoogle/cloud/storage/batch.py Outdated
Comment threadgoogle/cloud/storage/_helpers.py
Comment threadgoogle/cloud/storage/blob.py
Comment threadgoogle/cloud/storage/bucket.py
Comment threadtests/unit/test__signing.py Outdated
Comment threadtests/unit/test_batch.py Outdated
Comment threadtests/unit/test_blob.py
Comment threadtests/unit/test_client.py Outdated
@tseaver

tseaver commented Nov 26, 2021

Copy link
Copy Markdown
Contributor

@andrewsg The Kokoro system-2.7 job is configured both in the .kokoro/presubmit/system-2.7.cfg file and in google3.

@andrewsg

andrewsg commented Jan 7, 2022

Copy link
Copy Markdown
ContributorAuthor

@tseaver This was on hold due to the release freeze last month. Thank you as always for your thorough review. PTAL. Will address google3 issue shortly.

@parthea
parthea requested a review from tseaverJanuary 8, 2022 11:18
cojenco
cojenco reviewed Jan 11, 2022
View reviewed changes
Comment threadREADME.rst Outdated
@unforced

unforced commented Jan 11, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

So happy to see all the clean up. Nothing else to add beyond the requests that tres and cathy made; lgtm. Is there a change that should be made in here for kokoro to not try and still run the system-2.7 tests?
EDIT: Oh seems you already did.

@andrewsg@cojenco
Update README.rst
bc1f70b
Co-authored-by: cojenco <cathyo@google.com>
cojenco
cojenco reviewed Jan 12, 2022
View reviewed changes

@cojencocojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎉🎉 Thanks Andrew for getting us across the finish line!

@andrewsgandrewsg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 12, 2022
@andrewsg
andrewsg merged commit b611670 into mainJan 12, 2022
@andrewsg
andrewsg deleted the python-2-turndown branch January 12, 2022 18:12
This was referenced Jan 12, 2022
Merged
Closed
@release-pleaserelease-pleaseBot mentioned this pull request Aug 10, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@unforcedunforcedAwaiting requested review from unforced
2 more reviewers
@tseavertseavertseaver approved these changes
@cojencocojencocojenco approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tseavertseaver

Labels

api: storageIssues related to the googleapis/python-storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewsg@tseaver@unforced@cojenco