Uh oh!
There was an error while loading. Please reload this page.
fix: Fix BlobReader handling of interleaved reads and seeks - #721
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
6f876ee to
96fe0ecCompare
andrewsg
left a comment
There was a problem hiding this comment.
Thank you for your valuable contribution and especially for adding the test. I can see the problem was due to an inconsistent usage of reader._pos between the read and seek methods. I have one suggestion, which will fix the DeprecationWarnings in pytest output.
Uh oh!
There was an error while loading. Please reload this page.
96fe0ec to
d1631feCompare
andrewsg
left a comment
There was a problem hiding this comment.
Thank you! Will merge once system tests are complete.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes#462 🦕