Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: remove client side validations - #868

Merged
cojenco merged 5 commits into
googleapis:mainfrom
cojenco:error_msg
Oct 6, 2022
Merged

fix: remove client side validations#868
cojenco merged 5 commits into
googleapis:mainfrom
cojenco:error_msg

Conversation

@cojenco

@cojencocojenco commented Sep 20, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Remove client-side validations and fall back to API errors per internal review doc

  • included: errors raised with unknown type/value
    • STORAGE_CLASSES
    • HMAC _SETTABLE_STATES
  • excluded: client-side validations that are reasonable and can avoid wasteful processing with API actions

Fixes#879
Fixes#880

@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Sep 20, 2022
@cojencocojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2022
@cojencocojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2022
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 28, 2022
@cojenco
cojenco marked this pull request as ready for review September 29, 2022 21:36
@cojenco
cojenco requested review from a teamSeptember 29, 2022 21:36
andrewsg
andrewsg approved these changes Oct 5, 2022
View reviewed changes

@andrewsgandrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests as discussed

@cojenco
cojenco merged commit 928ebbc into googleapis:mainOct 6, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Oct 6, 2022
Merged
@cojenco
cojenco deleted the error_msg branch February 1, 2023 22:35
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@andrewsgandrewsgandrewsg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the googleapis/python-storage API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove client side validation in HMAC Key Remove client side validation for storage class inputs

3 participants

@cojenco@andrewsg@yoshi-kokoro