Display message when db.php isn't symlinked

[johnbillion]

In order to show extended information about DB queries, wp-content/db.php gets symlinked into the wp-content directory. If the plugin can't create this symlink it should display a message telling the user to do it manually in order to see the extended query information.

[franz-josef-kaiser]

About the ReflectionException: Instead of using @-error suppression, there should be a meaningful output or return value that can be used. Rule of thumb: Never hide errors, warnings or notices or you'll at some point during debugging want to kill yourself.

$error = NULL;
$db = content_url( 'db.php' );
if ( ! file_exists( $db )
{
 try {
 symlink( plugin_dir_path( 'wp-content/db.php' ), $db );
 }
 catch ( ReflectionException $e ) {
 $error = new WP_Error(
 'QueryMonitorError::SymlinkDBfileNotPossible',
 $e->getMessage(),
 $e
 );
 }
}
if ( is_wp_error( $error ) )
 return 'Puff the magic dragon was not so magic after all';

Just a draft from my head. Needs testing and later on some error checking. And I'm not sure if Exception for the catch isn't just enough. The less specific the better if we just want to "catch" it and transport it to WPs built in error notification system.

[johnbillion]

symlink() doesn't throw an exception. The comment above by jsmoriss about the uncaught ReflectionException was an unrelated issue which incorrectly referenced this one.

Regarding the @ error suppression - I agree. The only reason it's there is because the plugin doesn't care at that point whether the symlink is created or not (the plugin still works without it in place). My plan was to test for the file on each page load and show a message at the top of the queries panel. Good balance of visibility and non-intrusiveness that way.