[build] Update more NuGet package versions

Context: https://dev.azure.com/devdiv/DevDiv/_componentGovernance/112013/alert/2979569?typeId=6338203
[Component Governance][0] is a Microsoft internal tool which checks
for known security issues in product dependencies. It is currently
reporting a defect in Xamarin.Android because Java.Interop restores
the `System.Net.Http` v4.1.0 NuGet package, which contains security
vulnerability [CVE-2018-8292][1]:
/s/xamarin-android/external/Java.Interop/packages/system.net.http/4.1.0/system.net.http.4.1.0.nupkg
/s/xamarin-android/external/Java.Interop/packages/system.net.http/4.1.0/system.net.http.nuspec
`System.Net.Http` v4.1.0 isn't actually *used* by Java.Interop or
Xamarin.Android, it's just an implicit NuGet dependency of one of the
various NuGet packages which Java.Interop relies on.
The report is "noise".
That said, we should still remove "noise" when possible.
Update most NuGet package versions within Java.Interop to the latest
versions provided by `dotnet-public` or `dotnet-eng` (which may not
be the latest versions on NuGet.org).
Exceptions:
* `Microsoft.Xml.SgmlReader` is not bumped, as the latest version
introduced an ABI break.
* `Microsoft.CodeAnalysis.FxCopAnalyzers` v3.3.2 deprecated the
entire package, introducing additional warnings that I didn't
want to deal with right now.
* `protobuf-net` is still not updated, as the latest version causes
unit test failures; see also PR dotnet#878.
In order to better "centralize" NuGet package version information,
instead of having multiple `%(PackageReference.Version)` values
strewn throughout the codebase, instead have `.csproj` files contain
`@(PackageReference)`s that *don't* contain
`%(PackageReference.Version)`, and instead use [`%(Update)`][2] within
`Directory.Build.targets` to provide the actual package version:
<!-- .csproj -->
<PackageReference Include="Example" />
<!-- Directory.Build.targets -->
<PackageReference Update="Example" Version="1.0.0" />
This pattern requires that there be no "intervening"
`Directory.Build.targets` between the `.csproj` and the root directory;
see also the [MSBuild Customize your build][3] documentation.
Rename the existing `Directory.Build.targets` files to instead use
explicit `<Import/>`s against a newly added `.targets` file;
conceptually reverts part of d70e40f and later commits which use
`Directory.Build.targets`.
[0]: https://docs.opensource.microsoft.com/tools/cg/
[1]: https://nvd.nist.gov/vuln/detail/CVE-2018-8292
[2]: https://docs.microsoft.com/en-us/visualstudio/msbuild/item-element-msbuild?view=vs-2019#attributes-and-elements
[3]: https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build?view=vs-2019#directorybuildprops-and-directorybuildtargets

Author: jonpryor

Directory.Build.props

@@ -94,12 +94,4 @@
  <NoWarn>$(NoWarn);CA1307;CA1309;CA1310</NoWarn>
  </PropertyGroup>
 
-<!-- Add Roslyn analyzers NuGet to all projects -->
- <ItemGroupCondition=" '$(DisableRoslynAnalyzers)' != 'True' ">
- <PackageReferenceInclude="Microsoft.CodeAnalysis.FxCopAnalyzers"Version="3.3.0">
- <PrivateAssets>all</PrivateAssets>
- <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
- </PackageReference>
- </ItemGroup>
-
 </Project>

Directory.Build.targets

@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project>
+
+<!-- Add Roslyn analyzers NuGet to all projects -->
+ <ItemGroupCondition=" '$(DisableRoslynAnalyzers)' != 'True' ">
+ <PackageReferenceInclude="Microsoft.CodeAnalysis.FxCopAnalyzers"Version="3.3.0">
+ <PrivateAssets>all</PrivateAssets>
+ <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+ </PackageReference>
+ </ItemGroup>
+
+<!-- NuGet Dependencies -->
+ <ItemGroup>
+ <PackageReferenceUpdate="Microsoft.Xml.SgmlReader"Version="1.8.16" />
+ <PackageReferenceUpdate="GitInfo"Version="2.1.2" />
+ <PackageReferenceUpdate="HtmlAgilityPack"Version="1.11.30" />
+ <PackageReferenceUpdate="Irony"Version="1.1.0" />
+ <PackageReferenceUpdate="Microsoft.Build.Framework"Version="16.11.0" />
+ <PackageReferenceUpdate="Microsoft.Build.Utilities.Core"Version="16.11.0" />
+ <PackageReferenceUpdate="Microsoft.CodeAnalysis.CSharp"Version="3.11.0" />
+ <PackageReferenceUpdate="Microsoft.NET.Test.Sdk"Version="16.11.0" />
+ <PackageReferenceUpdate="Microsoft.NETFramework.ReferenceAssemblies"Version="1.0.2" />
+ <PackageReferenceUpdate="Mono.CSharp"Version="4.0.0.143" />
+ <PackageReferenceUpdate="Mono.Linq.Expressions"Version="2.0.0" />
+ <PackageReferenceUpdate="Mono.Options"Version="6.12.0.148" />
+ <PackageReferenceUpdate="Mono.Terminal"Version="5.4.2" />
+ <PackageReferenceUpdate="nunit"Version="3.13.2" />
+ <PackageReferenceUpdate="NUnit.ConsoleRunner"Version="3.12.0" />
+ <PackageReferenceUpdate="NUnit3TestAdapter"Version="4.0.0">
+ <PrivateAssets>all</PrivateAssets>
+ <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+ </PackageReference>
+ <PackageReferenceUpdate="protobuf-net"Version="2.4.4" />
+ <PackageReferenceUpdate="XliffTasks"Version="1.0.0-beta.20420.1" />
+ </ItemGroup>
+
+</Project>

build-tools/Java.Interop.BootstrapTasks/Java.Interop.BootstrapTasks.csproj

@@ -7,8 +7,8 @@
  </PropertyGroup>
 
  <ItemGroup>
- <PackageReferenceInclude="Microsoft.Build.Framework"Version="16.5.0"/>
- <PackageReferenceInclude="Microsoft.Build.Utilities.Core"Version="16.5.0"/>
+ <PackageReferenceInclude="Microsoft.Build.Framework" />
+ <PackageReferenceInclude="Microsoft.Build.Utilities.Core" />
  </ItemGroup>
 
  <ItemGroup>

build-tools/jnienv-gen/jnienv-gen.csproj

@@ -12,6 +12,6 @@
  </PropertyGroup>
 
  <ItemGroup>
- <PackageReferenceInclude="Microsoft.NETFramework.ReferenceAssemblies"PrivateAssets="All"Version="1.0.0"/>
+ <PackageReferenceInclude="Microsoft.NETFramework.ReferenceAssemblies"PrivateAssets="All" />
  </ItemGroup>
 </Project>

build-tools/scripts/RunNUnitTests.targets

@@ -5,7 +5,7 @@
  <_TopDir>$(MSBuildThisFileDirectory)..\..</_TopDir>
  <_RuntimeCondition=" '$(RUNTIME)' != '' ">$(RUNTIME)</_Runtime>
  <_RuntimeCondition=" '$(RUNTIME)' == '' And '$(OS)' != 'Windows_NT' ">mono --debug</_Runtime>
- <_NUnit>$(_Runtime) packages\nunit.consolerunner\3.11.1\tools\nunit3-console.exe</_NUnit>
+ <_NUnit>$(_Runtime) packages\nunit.consolerunner\3.12.0\tools\nunit3-console.exe</_NUnit>
  <_RunCondition=" '$(RUN)' != '' ">--run=&quot;$(RUN)&quot;</_Run>
  </PropertyGroup>
  <Import

build-tools/scripts/VersionInfo.targets

@@ -8,7 +8,7 @@
  <GitThisAssembly>false</GitThisAssembly>
  </PropertyGroup>
  <ItemGroup>
- <PackageReferenceInclude="GitInfo"Version="2.1.2"PrivateAssets="all" />
+ <PackageReferenceInclude="GitInfo"PrivateAssets="all" />
  </ItemGroup>
 
  <TargetName="GenerateVersionInfo"

samples/Hello/Hello.csproj

@@ -12,7 +12,7 @@
  </PropertyGroup>
 
  <ItemGroup>
- <PackageReferenceInclude="Microsoft.NETFramework.ReferenceAssemblies"PrivateAssets="All"Version="1.0.0"/>
+ <PackageReferenceInclude="Microsoft.NETFramework.ReferenceAssemblies"PrivateAssets="All" />
  </ItemGroup>
 
  <ItemGroup>

src/Java.Interop.Localization/Java.Interop.Localization.csproj

@@ -11,7 +11,7 @@
  </PropertyGroup>
 
  <ItemGroup>
- <PackageReferenceInclude="XliffTasks"Version="1.0.0-beta.20420.1"/>
+ <PackageReferenceInclude="XliffTasks" />
  </ItemGroup>
 
  <ItemGroup>

src/Java.Interop.Tools.JavaSource/Java.Interop.Tools.JavaSource.csproj

@@ -15,7 +15,7 @@
  <CompileInclude="..\utils\NullableAttributes.cs" />
  </ItemGroup>
  <ItemGroup>
- <PackageReferenceInclude="Irony"Version="1.1.0"/>
+ <PackageReferenceInclude="Irony" />
  </ItemGroup>
  <ItemGroup>
  <ProjectReferenceInclude="..\Xamarin.Android.Tools.ApiXmlAdjuster\Xamarin.Android.Tools.ApiXmlAdjuster.csproj" />

src/Java.Interop/Java.Interop-MonoAndroid.csproj

@@ -83,7 +83,7 @@
  <Private>False</Private>
  </Reference>
  </ItemGroup>
- <ImportProject="Directory.Build.targets" />
+ <ImportProject="Java.Interop.targets" />
  <PropertyGroup>
  <BuildDependsOn>
  BuildJniEnvironment_g_cs;