node v0.10.34 causes untrusted cert errors

[nicks]

Install the request module and run the following code:

var r = require('request')
r.get('https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-1.9.8-macosx.zip')

Expected behavior:
Fetches the file and exits

Actual behavior:

events.js:72
 throw er; // Unhandled 'error' event
 ^
Error: CERT_UNTRUSTED
 at SecurePair.<anonymous> (tls.js:1381:32)
 at SecurePair.emit (events.js:92:17)
 at SecurePair.maybeInitFinished (tls.js:980:10)

This works as expected in Node v0.10.33, but fails in Node v0.10.34

[misterdjules]

Thank you very much for reporting this issue @nicks. This is due to the update of root certificates that was included in the 0.10.34 release.

Putting @indutny and @bnoordhuis in the loop since they're most familiar with this change.

[misterdjules]

@indutny If I add the /* Verisign Class 3 Public Primary Certification Authority */ root cert back into src/node_root_certs.h, I can't reproduce the issue.

[ploer]

Seems like this is fairly widespread; I'm seeing the same problem with amazon servers.

var r = require('request')
r.get('https://s3.amazonaws.com')

[indutny]

@misterdjules yeah, I just wanted to paste the same thing:

diff --git a/src/node_root_certs.h b/src/node_root_certs.h
index 336eeb5..3eddb68 100644
--- a/src/node_root_certs.h
+++ b/src/node_root_certs.h
@@ -88,6 +88,21 @@
 "2zsmWLIodz2uFHdh1voqZiegDfqnc1zqcPGUIWVEX/r87yloqaKHee9570+sB3c4\n"
 "-----END CERTIFICATE-----\n",

+/* Verisign Class 3 Public Primary Certification Authority */
+"-----BEGIN CERTIFICATE-----\n"
+"MIICPDCCAaUCEHC65B0Q2Sk0tjjKewPMur8wDQYJKoZIhvcNAQECBQAwXzELMAkGA1UEBhMC\n"
+"VVMxFzAVBgNVBAoTDlZlcmlTaWduLCBJbmMuMTcwNQYDVQQLEy5DbGFzcyAzIFB1YmxpYyBQ\n"
+"cmltYXJ5IENlcnRpZmljYXRpb24gQXV0aG9yaXR5MB4XDTk2MDEyOTAwMDAwMFoXDTI4MDgw\n"
+"MTIzNTk1OVowXzELMAkGA1UEBhMCVVMxFzAVBgNVBAoTDlZlcmlTaWduLCBJbmMuMTcwNQYD\n"
+"VQQLEy5DbGFzcyAzIFB1YmxpYyBQcmltYXJ5IENlcnRpZmljYXRpb24gQXV0aG9yaXR5MIGf\n"
+"MA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDJXFme8huKARS0EN8EQNvjV69qRUCPhAwL0TPZ\n"
+"2RHP7gJYHyX3KqhEBarsAx94f56TuZoAqiN91qyFomNFx3InzPRMxnVx0jnvT0Lwdd8KkMaO\n"
+"IG+YD/isI19wKTakyYbnsZogy1Olhec9vn2a/iRFM9x2Fe0PonFkTGUugWhFpwIDAQABMA0G\n"
+"CSqGSIb3DQEBAgUAA4GBALtMEivPLCYATxQT3ab7/AoRhIzzKBxnki98tsX63/Dolbwdj2ws\n"
+"qFHMc9ikwFPwTtYmwHYBV4GSXiHx0bH/59AhWM1pF+NEHJwZRDmJXNycAA9WjQKZ7aKQRUzk\n"
+"uxCkPfAyAw7xzvjoyVGM5mKf5p/AfbdynMk2OmufTqj/ZA1k\n"
+"-----END CERTIFICATE-----\n",
+
 /* Verisign Class 3 Public Primary Certification Authority - G2 */
 "-----BEGIN CERTIFICATE-----\n"
 "MIIDAjCCAmsCEH3Z/gfPqB63EHln+6eJNMYwDQYJKoZIhvcNAQEFBQAwgcExCzAJBgNVBAYT\n"

[indutny]

VeriSign Class 3 Public Primary CA
Description: Description: This root CA is the root used for Secure Site Pro Certificates ,
Premium SSL Certificates and Code Signing Certificates. It is intended to be the
primary root used for these products until Q4 2010 when VeriSign transitions to using
a 2048 bit root. After that transition this CA will be used as part of a cross certification
to ensure legacy applications continue to trust VeriSign certificates and must continue
to be included in root stores by vendors. This root is expected to be used in this way at
least until 12/31/2013 and vendors should not plan on removing support for this root
until officially advised that the root is no longer needed to support certificates or CRL
validation. 

[indutny]

@misterdjules it doesn't work in firefox anymore, but does work in chrome and safari. The test url is: https://ssltest23.bbtest.net/

[indutny]

Relevant mozilla page: https://blog.mozilla.org/security/2014/09/08/phasing-out-certificates-with-1024-bit-rsa-keys/

[indutny]

@misterdjules basically it has 1024-bit RSA private key so it is insecure. I guess we are doing the right job here and it doesn't need to be fixed.

[indutny]

@nicks @ploer this is not a final decision, but I'm afraid that this is the "right thing to do" about Amazon certificates. Technically, you could just use rejectUnauthorized: false to make it work. This won't provide any security risks since that 1024 bit certificate could be cracked in months, and probably already was (if someone ever needed it).

[nicks]

when you say "it doesn't work in firefox anymore", can you give more details? The link works fine for me on firefox 34, and Firefox claims the SSL certs are OK.

[nicks]

AFAICT, https://bbuseruploads.s3.amazonaws.com successfully accepts a 2048-bit cert on all browsers that I tried, but doesn't with node

[indutny]

@nicks You are right about bbuseruploads, checking it. Note that I was talking about 1024-bit CA cert, not the leaf bbuseruploads cert.

[shigeki]

It was pointed out at https://bugzilla.mozilla.org/show_bug.cgi?id=986005#c4 . For a temporary remedy, shigeki/node@604752c allows 1024-bit rootCA.