From a596bcaca8874f47095eeecc86e788b22b2269ca Mon Sep 17 00:00:00 2001 From: Tanguy Krotoff Date: Fri, 30 Oct 2015 09:38:41 +0100 Subject: [PATCH 1/2] Missing semicolons --- test/test.js | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/test/test.js b/test/test.js index 2a047b1..0bf8f40 100644 --- a/test/test.js +++ b/test/test.js @@ -6,7 +6,7 @@ var create = require('..'); describe('HTTP Errors', function () { it('create(status)', function () { var err = create(404); - assert.equal(err.name, 'NotFoundError') + assert.equal(err.name, 'NotFoundError'); assert.equal(err.message, 'Not Found'); assert.equal(err.status, 404); assert.equal(err.statusCode, 404); @@ -21,7 +21,7 @@ describe('HTTP Errors', function () { it('create(status, msg)', function () { var err = create(404, 'LOL'); - assert.equal(err.name, 'NotFoundError') + assert.equal(err.name, 'NotFoundError'); assert.equal(err.message, 'LOL'); assert.equal(err.status, 404); assert.equal(err.statusCode, 404); @@ -30,8 +30,8 @@ describe('HTTP Errors', function () { it('create(status, props)', function () { var err = create(404, { id: 1 - }) - assert.equal(err.name, 'NotFoundError') + }); + assert.equal(err.name, 'NotFoundError'); assert.equal(err.message, 'Not Found'); assert.equal(err.status, 404); assert.equal(err.statusCode, 404); @@ -42,8 +42,8 @@ describe('HTTP Errors', function () { var err = create(404, { id: 1, status: 500 - }) - assert.equal(err.name, 'NotFoundError') + }); + assert.equal(err.name, 'NotFoundError'); assert.equal(err.message, 'Not Found'); assert.equal(err.status, 404); assert.equal(err.statusCode, 404); @@ -54,8 +54,8 @@ describe('HTTP Errors', function () { var err = create(404, { id: 1, statusCode: 500 - }) - assert.equal(err.name, 'NotFoundError') + }); + assert.equal(err.name, 'NotFoundError'); assert.equal(err.message, 'Not Found'); assert.equal(err.status, 404); assert.equal(err.statusCode, 404); @@ -67,7 +67,7 @@ describe('HTTP Errors', function () { id: 1 }); assert.equal(err.id, 1); - assert.equal(err.name, 'InternalServerError') + assert.equal(err.name, 'InternalServerError'); assert.equal(err.message, 'Internal Server Error'); assert.equal(err.status, 500); assert.equal(err.statusCode, 500); @@ -75,7 +75,7 @@ describe('HTTP Errors', function () { it('create(msg, status)', function () { var err = create('LOL', 404); - assert.equal(err.name, 'NotFoundError') + assert.equal(err.name, 'NotFoundError'); assert.equal(err.message, 'LOL'); assert.equal(err.status, 404); assert.equal(err.statusCode, 404); @@ -83,7 +83,7 @@ describe('HTTP Errors', function () { it('create(msg)', function () { var err = create('LOL'); - assert.equal(err.name, 'InternalServerError') + assert.equal(err.name, 'InternalServerError'); assert.equal(err.message, 'LOL'); assert.equal(err.status, 500); assert.equal(err.statusCode, 500); @@ -93,7 +93,7 @@ describe('HTTP Errors', function () { var err = create('LOL', { id: 1 }); - assert.equal(err.name, 'InternalServerError') + assert.equal(err.name, 'InternalServerError'); assert.equal(err.message, 'LOL'); assert.equal(err.status, 500); assert.equal(err.statusCode, 500); @@ -166,13 +166,13 @@ describe('HTTP Errors', function () { it('create(status, msg, { expose: false })', function () { var err = create(404, 'LOL', { expose: false - }) - assert.equal(err.expose, false) + }); + assert.equal(err.expose, false); }) it('new create.NotFound()', function () { var err = new create.NotFound(); - assert.equal(err.name, 'NotFoundError') + assert.equal(err.name, 'NotFoundError'); assert.equal(err.message, 'Not Found'); assert.equal(err.status, 404); assert.equal(err.statusCode, 404); @@ -182,7 +182,7 @@ describe('HTTP Errors', function () { it('new create.InternalServerError()', function () { var err = new create.InternalServerError(); - assert.equal(err.name, 'InternalServerError') + assert.equal(err.name, 'InternalServerError'); assert.equal(err.message, 'Internal Server Error'); assert.equal(err.status, 500); assert.equal(err.statusCode, 500); @@ -192,7 +192,7 @@ describe('HTTP Errors', function () { it('new create["404"]()', function () { var err = new create['404'](); - assert.equal(err.name, 'NotFoundError') + assert.equal(err.name, 'NotFoundError'); assert.equal(err.message, 'Not Found'); assert.equal(err.status, 404); assert.equal(err.statusCode, 404); @@ -202,13 +202,13 @@ describe('HTTP Errors', function () { it('should preserve error [[Class]]', function () { var err = new create('LOL'); - assert.equal(Object.prototype.toString.call(err), '[object Error]') + assert.equal(Object.prototype.toString.call(err), '[object Error]'); var err = new create[404](); - assert.equal(Object.prototype.toString.call(err), '[object Error]') + assert.equal(Object.prototype.toString.call(err), '[object Error]'); var err = new create[500](); - assert.equal(Object.prototype.toString.call(err), '[object Error]') + assert.equal(Object.prototype.toString.call(err), '[object Error]'); }) it('should support err instanceof Error', function () { From eae8abc453b3d1a9963cfb9e415c0031210b91a3 Mon Sep 17 00:00:00 2001 From: Tanguy Krotoff Date: Fri, 30 Oct 2015 09:39:49 +0100 Subject: [PATCH 2/2] Make the asserts more consistent over the tests --- test/test.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/test/test.js b/test/test.js index 0bf8f40..4e9a29d 100644 --- a/test/test.js +++ b/test/test.js @@ -14,6 +14,7 @@ describe('HTTP Errors', function () { it('create(status) for 300', function () { var err = create(300); + assert.equal(err.name, 'Error'); assert.equal(err.message, 'Multiple Choices'); assert.equal(err.status, 300); assert.equal(err.statusCode, 300); @@ -66,11 +67,11 @@ describe('HTTP Errors', function () { var err = create({ id: 1 }); - assert.equal(err.id, 1); assert.equal(err.name, 'InternalServerError'); assert.equal(err.message, 'Internal Server Error'); assert.equal(err.status, 500); assert.equal(err.statusCode, 500); + assert.equal(err.id, 1); }) it('create(msg, status)', function () { @@ -105,25 +106,28 @@ describe('HTTP Errors', function () { _err.status = 404; var err = create(_err); assert.equal(err, _err); + assert.equal(err.name, 'Error'); assert.equal(err.message, 'LOL'); assert.equal(err.status, 404); + assert.equal(err.statusCode, 404); assert.equal(err.expose, true); _err = new Error('LOL'); err = create(_err); assert.equal(err, _err); + assert.equal(err.name, 'Error'); assert.equal(err.message, 'LOL'); assert.equal(err.status, 500); assert.equal(err.statusCode, 500); assert.equal(err.expose, false); }) - it('create(err) with invalid err.status', function () { var _err = new Error('Connection refused'); _err.status = -1; var err = create(_err); assert.equal(err, _err); + assert.equal(err.name, 'Error'); assert.equal(err.message, 'Connection refused'); assert.equal(err.status, 500); assert.equal(err.statusCode, 500); @@ -136,8 +140,10 @@ describe('HTTP Errors', function () { var err = create(_err, { id: 1 }); + assert.equal(err.name, 'Error'); assert.equal(err.message, 'LOL'); assert.equal(err.status, 404); + assert.equal(err.statusCode, 404); assert.equal(err.id, 1); assert.equal(err.expose, true); }) @@ -148,9 +154,11 @@ describe('HTTP Errors', function () { id: 1 }); assert.equal(err, _err); + assert.equal(err.name, 'Error'); assert.equal(err.message, 'LOL'); assert.equal(err.status, 404); assert.equal(err.statusCode, 404); + assert.equal(err.id, 1); }) it('create(status, msg, props)', function () { @@ -161,6 +169,7 @@ describe('HTTP Errors', function () { assert.equal(err.message, 'LOL'); assert.equal(err.status, 404); assert.equal(err.statusCode, 404); + assert.equal(err.id, 1); }) it('create(status, msg, { expose: false })', function () {