Skip to content

Commit 0d70809

Browse files
authored
feat(deps): Remove core-js dependency. (#3379)
The core-js was used for dom-serialize, used to support a single function in stringify (serialize) for a single rare browser, IE8, in logs sent back to the server. By dropping this dependency we reduce the size of karma with minimal impact on use cases.
1 parent 3ffcd83 commit 0d70809

5 files changed

Lines changed: 1527 additions & 1526 deletions

File tree

‎client/main.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/* global io */
22
/* eslint-disable no-new */
33

4-
require('core-js/stable')
54
varKarma=require('./karma')
65
varStatusUpdater=require('./updater')
76
varutil=require('../common/util')

‎common/stringify.js‎

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
1-
varserialize=require('dom-serialize')
1+
varserialize=null
2+
try{
3+
serialize=require('dom-serialize')
4+
}catch(e){
5+
// Ignore failure on IE8
6+
}
7+
28
varinstanceOf=require('./util').instanceOf
39

410
functionisNode(obj){
@@ -56,7 +62,11 @@ function stringify (obj, depth) {
5662
}elseif(obj.outerHTML){
5763
returnobj.outerHTML
5864
}elseif(isNode(obj)){
59-
returnserialize(obj)
65+
if(serialize){
66+
returnserialize(obj)
67+
}else{
68+
return'Skipping stringify, no support for dom-serialize'
69+
}
6070
}elseif(instanceOf(obj,'Error')){
6171
returnobj.toString()+'\n'+obj.stack
6272
}else{

0 commit comments

Comments
 (0)