fix(web): satisfy ssh terminal lint and test diagnostics

Replace optional-chain access on globalThis.crypto with a typed cast
so @typescript-eslint/no-unnecessary-condition stops flagging the
SSH terminal id helpers. Drop the Math.random fallback in favor of a
counter-based id to avoid sonarjs/pseudo-random while still producing
unique placeholders when the Web Crypto API is missing. Type the
hoisted vitest mocks for openProjectEventStream and
startProjectTerminalSession so the test no longer triggers the
@typescript-eslint/no-unsafe-* rules, and adjust the deterministic
test to assert the new pending session id format.

Author: konard

packages/app/src/web/actions-projects.ts

@@ -13,9 +13,9 @@ import {
 }from"./actions-shared.js"
 import{loadSelectedProjectTasks}from"./actions-tasks.js"
 import{
+typeApiEvent,
 applyAllProjects,
 applyProject,
-typeApiEvent,
 deleteProject,
 downAllProjects,
 downProject,
@@ -78,30 +78,30 @@ const resolveProjectTerminalKey = (
 returnnull
 }
 
-constrandomHex=(bytes: number): string=>{
-constgetRandomValues=globalThis.crypto?.getRandomValues
-if(typeofgetRandomValues==="function"){
-constvalues=newUint8Array(bytes)
-getRandomValues.call(globalThis.crypto,values)
-returnArray.from(values,(value)=>value.toString(16).padStart(2,"0")).join("")
-}
+letpendingTerminalSessionCounter=0
 
-letfallback=""
-while(fallback.length<bytes*2){
-fallback+=Math.floor(Math.random()*0x1_0000_0000)
-.toString(16)
-.padStart(8,"0")
+constcryptoRandomHex=(bytes: number): string|null=>{
+constcryptoApi=globalThis.cryptoasCrypto|undefined
+if(cryptoApi===undefined||typeofcryptoApi.getRandomValues!=="function"){
+returnnull
 }
-returnfallback.slice(0,bytes*2)
+constvalues=newUint8Array(bytes)
+cryptoApi.getRandomValues(values)
+returnArray.from(values,(value)=>value.toString(16).padStart(2,"0")).join("")
 }
 
 constcreatePendingTerminalSessionId=(): string=>{
-constrandomUUID=globalThis.crypto?.randomUUID
-if(typeofrandomUUID==="function"){
-returnrandomUUID.call(globalThis.crypto)
+constcryptoApi=globalThis.cryptoasCrypto|undefined
+if(cryptoApi!==undefined&&typeofcryptoApi.randomUUID==="function"){
+returncryptoApi.randomUUID()
 }
-
-return`pending-${Date.now().toString(16)}-${randomHex(8)}`
+constrandomSuffix=cryptoRandomHex(8)
+if(randomSuffix!==null){
+return`pending-${Date.now().toString(16)}-${randomSuffix}`
+}
+pendingTerminalSessionCounter=(pendingTerminalSessionCounter+1)>>>0
+constcounterSuffix=pendingTerminalSessionCounter.toString(16).padStart(8,"0")
+return`pending-${Date.now().toString(16)}-${counterSuffix}`
 }
 
 constreadEventPayloadString=(

packages/app/src/web/api-types.ts

@@ -23,8 +23,9 @@ import type {
 exporttypeProjectSummary=Schema.Schema.Type<typeofProjectSummarySchema>
 exporttypeProjectDetails=Schema.Schema.Type<typeofProjectDetailsSchema>
 exporttypeCreateProjectAcceptedResponse=Schema.Schema.Type<typeofCreateProjectAcceptedResponseSchema>
-exporttypeStartProjectTerminalSessionAccepted=
-Schema.Schema.Type<typeofStartProjectTerminalSessionAcceptedResponseSchema>
+exporttypeStartProjectTerminalSessionAccepted=Schema.Schema.Type<
+typeofStartProjectTerminalSessionAcceptedResponseSchema
+>
 exporttypeProjectPortForward=Schema.Schema.Type<typeofProjectPortForwardSchema>
 exporttypeProjectBrowserSession=Schema.Schema.Type<typeofProjectBrowserSessionSchema>
 exporttypeProjectDatabaseForward=Schema.Schema.Type<typeofProjectDatabaseForwardSchema>

packages/app/tests/docker-git/actions-projects.test.ts

@@ -3,16 +3,36 @@ import { Effect } from "effect"
 import{afterEach,beforeEach,vi}from"vitest"
 
 import{applyProjectById,connectProjectById,runApplyAllProjects}from"../../src/web/actions-projects.js"
-importtype{ProjectDetails,StartProjectTerminalSessionAccepted,TerminalSession}from"../../src/web/api.js"
+importtype{
+ApiEvent,
+ProjectDetails,
+StartProjectTerminalSessionAccepted,
+TerminalSession
+}from"../../src/web/api.js"
 importtype{ActiveTerminalSession}from"../../src/web/terminal.js"
 import{makeBrowserActionContext,waitForAssertion}from"./browser-action-context-fixture.js"
 
+typeEventStreamHandlersFixture={
+readonlyonLine: (line: string)=>void
+readonlyonEvent?: (event: ApiEvent)=>void
+readonlyonRateLimit: ()=>void
+readonlyinitialCursor?: number|undefined
+}
+
+typeEventStreamControlsFixture={
+readonlyclose: ()=>void
+}
+
 constapplyAllProjectsMock=vi.hoisted(()=>vi.fn())
 constapplyProjectMock=vi.hoisted(()=>vi.fn())
 consteventStreamCloseMock=vi.hoisted(()=>vi.fn())
 constloadProjectTerminalSessionMock=vi.hoisted(()=>vi.fn())
-constopenProjectEventStreamMock=vi.hoisted(()=>vi.fn())
-conststartProjectTerminalSessionMock=vi.hoisted(()=>vi.fn())
+constopenProjectEventStreamMock=vi.hoisted(()=>
+vi.fn<(projectId: string,handlers: EventStreamHandlersFixture)=>EventStreamControlsFixture>()
+)
+conststartProjectTerminalSessionMock=vi.hoisted(()=>
+vi.fn<(projectKey: string,requestId: string)=>Effect.Effect<StartProjectTerminalSessionAccepted>>()
+)
 
 vi.mock("../../src/web/api.js",()=>({
 applyAllProjects: applyAllProjectsMock,
@@ -194,8 +214,7 @@ describe("web project actions", () => {
 
 it.effect("starts SSH terminal creation when randomUUID is unavailable",()=>
 Effect.gen(function*(_){
-constdateNowMock=vi.spyOn(Date,"now").mockReturnValue(0x1234)
-constmathRandomMock=vi.spyOn(Math,"random").mockReturnValue(0.5)
+constdateNowMock=vi.spyOn(Date,"now").mockReturnValue(0x12_34)
 vi.stubGlobal("crypto",{})
 startProjectTerminalSessionMock.mockImplementation((_projectKey,requestId: string)=>
 Effect.succeed(startTerminalAccepted(requestId))
@@ -215,10 +234,10 @@ describe("web project actions", () => {
 }))
 
 constrequestId=startProjectTerminalSessionMock.mock.calls[0]?.[1]
-expect(requestId).toBe("pending-1234-8000000080000000")
+expect(typeofrequestId).toBe("string")
+expect(requestId).toMatch(/^pending-1234-[0-9a-f]{8}$/)
 expect(addTerminalSession).toHaveBeenCalledTimes(1)
 expect(openProjectEventStreamMock).toHaveBeenCalledTimes(1)
-mathRandomMock.mockRestore()
 dateNowMock.mockRestore()
 }))