Skip to content

Replace hardcoded toolbar breakpoints with KListWithOverflow#5707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexVelezLl merged 8 commits into from
Jun 12, 2026
Merged

Replace hardcoded toolbar breakpoints with KListWithOverflow #5707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aa91e96
Replace hardcoded toolbar breakpoints with KListWithOverflow
nucleogenesis Feb 16, 2026
0ffe3f0
Standardize toolbarGroups
AlexVelezLl May 20, 2026
c4d390f
Overflow items into KDropdownMenu
AlexVelezLl May 27, 2026
c2d2092
Add dividers
AlexVelezLl May 27, 2026
2e14f9d
Add skip prop to unsupported groups
AlexVelezLl May 27, 2026
bdf7341
Follow codebase conventions
AlexVelezLl May 27, 2026
c83d4a9
Polish last details
AlexVelezLl Jun 4, 2026
fd0cb4d
Update KDS version
AlexVelezLl Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...curation/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/TipTapEditor.vue
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -183,12 +183,11 @@
};

onMounted(() => {
// capture
document.addEventListener('click', handleClickOutside, true);
document.addEventListener('click', handleClickOutside);
});

onUnmounted(() => {
document.removeEventListener('click', handleClickOutside, true);
Comment on lines -186 to -191

@AlexVelezLlAlexVelezLlJun 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to remove this last true so that the event listener triggered the handler on the event bubble instead of doing so on the event capture phase; this leaves us space to call .stopPropagation on nodes outside the tiptap editor DOM tree (e.g., KDropdown renders the dropdown in a different dropdown layer). I have tested this extensively and haven't found any unexpected regression.

document.removeEventListener('click', handleClickOutside);
});

const getMarkdownContent = () => {
Expand Down
Loading
Loading