Skip to content

Enhance onchain transaction management#628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 2 commits into from
Feb 20, 2026
Merged

Enhance onchain transaction management #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38f9a87
Rebroadcast unconfirmed transactions on each new block
Camillarhi Sep 5, 2025
d9d061c
Implement RBF fee bumping for unconfirmed transactions
Camillarhi Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bindings/ldk_node.udl
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -277,6 +277,8 @@ interface OnchainPayment {
Txid send_to_address([ByRef]Address address, u64 amount_sats, FeeRate? fee_rate);
[Throws=NodeError]
Txid send_all_to_address([ByRef]Address address, boolean retain_reserve, FeeRate? fee_rate);
[Throws=NodeError]
Txid bump_fee_rbf(PaymentId payment_id, FeeRate? fee_rate);
};

interface FeeRate {
Expand Down
17 changes: 17 additions & 0 deletions src/payment/onchain.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use std::sync::{Arc, RwLock};

use bitcoin::{Address, Txid};
use lightning::ln::channelmanager::PaymentId;

use crate::config::Config;
use crate::error::Error;
Expand DownExpand Up@@ -120,4 +121,20 @@ impl OnchainPayment {
let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
self.wallet.send_to_address(address, send_amount, fee_rate_opt)
}

/// Attempt to bump the fee of an unconfirmed transaction using Replace-by-Fee (RBF).
///
/// This creates a new transaction that replaces the original one, increasing the fee by the
/// specified increment to improve its chances of confirmation.
///
/// The new transaction will have the same outputs as the original but with a
/// higher fee, resulting in faster confirmation potential.
///
/// Returns the [`Txid`] of the new replacement transaction if successful.
pub fn bump_fee_rbf(
&self, payment_id: PaymentId, fee_rate: Option<FeeRate>,
) -> Result<Txid, Error> {
let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
self.wallet.bump_fee_rbf(payment_id, fee_rate_opt)
}
}
11 changes: 6 additions & 5 deletions src/payment/pending_payment_store.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,10 +84,11 @@ impl StorableObjectUpdate<PendingPaymentDetails> for PendingPaymentDetailsUpdate

impl From<&PendingPaymentDetails> for PendingPaymentDetailsUpdate {
fn from(value: &PendingPaymentDetails) -> Self {
Self {
id: value.id(),
payment_update: Some(value.details.to_update()),
conflicting_txids: Some(value.conflicting_txids.clone()),
}
let conflicting_txids = if value.conflicting_txids.is_empty() {
None
} else {
Some(value.conflicting_txids.clone())
};
Self { id: value.id(), payment_update: Some(value.details.to_update()), conflicting_txids }
}
}
18 changes: 15 additions & 3 deletions src/payment/store.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -291,6 +291,15 @@ impl StorableObject for PaymentDetails {
}
}

if let Some(tx_id) = update.txid {
match self.kind {
PaymentKind::Onchain { ref mut txid, .. } => {
update_if_necessary!(*txid, tx_id);
},
_ => {},
}
}

if updated {
self.latest_update_timestamp = SystemTime::now()
.duration_since(UNIX_EPOCH)
Expand DownExpand Up@@ -540,6 +549,7 @@ pub(crate) struct PaymentDetailsUpdate {
pub direction: Option<PaymentDirection>,
pub status: Option<PaymentStatus>,
pub confirmation_status: Option<ConfirmationStatus>,
pub txid: Option<Txid>,
}

impl PaymentDetailsUpdate {
Expand All@@ -555,6 +565,7 @@ impl PaymentDetailsUpdate {
direction: None,
status: None,
confirmation_status: None,
txid: None,
}
}
}
Expand All@@ -570,9 +581,9 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
_ => (None, None, None),
};

let confirmation_status= match value.kind {
PaymentKind::Onchain { status, .. } => Some(status),
_ => None,
let (confirmation_status, txid) = match &value.kind {
PaymentKind::Onchain { status, txid, .. } => (Some(*status), Some(*txid)),
_ => (None, None),
};

let counterparty_skimmed_fee_msat = match value.kind {
Expand All@@ -593,6 +604,7 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
direction: Some(value.direction),
status: Some(value.status),
confirmation_status,
txid,
}
}
}
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Enhance onchain transaction management by Camillarhi · Pull Request #628 · lightningdevkit/ldk-node · GitHub
Skip to content
Enhance onchain transaction management#628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Feb 20, 2026
 Merged


Enhance onchain transaction management
#628
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
38f9a87

Rebroadcast unconfirmed transactions on each new block


Camillarhi Sep 5, 2025
d9d061c

Implement RBF fee bumping for unconfirmed transactions


Camillarhi Jan 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
bindings/ldk_node.udl

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -277,6 +277,8 @@ interface OnchainPayment {
	Txid send_to_address([ByRef]Address address, u64 amount_sats, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid send_all_to_address([ByRef]Address address, boolean retain_reserve, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid bump_fee_rbf(PaymentId payment_id, FeeRate? fee_rate);
};

interface FeeRate {
Expand Down

17 changes: 17 additions & 0 deletions
src/payment/onchain.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use std::sync::{Arc, RwLock};

use bitcoin::{Address, Txid};
use lightning::ln::channelmanager::PaymentId;

use crate::config::Config;
use crate::error::Error;
Expand DownExpand Up@@ -120,4 +121,20 @@ impl OnchainPayment {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.send_to_address(address, send_amount, fee_rate_opt)
	}

	/// Attempt to bump the fee of an unconfirmed transaction using Replace-by-Fee (RBF).
	///
	/// This creates a new transaction that replaces the original one, increasing the fee by the
	/// specified increment to improve its chances of confirmation.
	///
	/// The new transaction will have the same outputs as the original but with a
	/// higher fee, resulting in faster confirmation potential.
	///
	/// Returns the [`Txid`] of the new replacement transaction if successful.
	pub fn bump_fee_rbf(
 &self, payment_id: PaymentId, fee_rate: Option<FeeRate>,
	) -> Result<Txid, Error> {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.bump_fee_rbf(payment_id, fee_rate_opt)
	}
}

11 changes: 6 additions & 5 deletions
src/payment/pending_payment_store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,10 +84,11 @@ impl StorableObjectUpdate<PendingPaymentDetails> for PendingPaymentDetailsUpdate

impl From<&PendingPaymentDetails> for PendingPaymentDetailsUpdate {
	fn from(value: &PendingPaymentDetails) -> Self {
 Self {
 id: value.id(),
 payment_update: Some(value.details.to_update()),
 conflicting_txids: Some(value.conflicting_txids.clone()),
 }
 let conflicting_txids = if value.conflicting_txids.is_empty() {
 None
 } else {
 Some(value.conflicting_txids.clone())
 };
 Self { id: value.id(), payment_update: Some(value.details.to_update()), conflicting_txids }
	}
}

18 changes: 15 additions & 3 deletions
src/payment/store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,6 +291,15 @@ impl StorableObject for PaymentDetails {
 }
 }

 if let Some(tx_id) = update.txid {
 match self.kind {
 PaymentKind::Onchain { ref mut txid, .. } => {
 update_if_necessary!(*txid, tx_id);
 },
 _ => {},
 }
 }

 if updated {
 self.latest_update_timestamp = SystemTime::now()
 .duration_since(UNIX_EPOCH)
Expand DownExpand Up@@ -540,6 +549,7 @@ pub(crate) struct PaymentDetailsUpdate {
	pub direction: Option<PaymentDirection>,
	pub status: Option<PaymentStatus>,
	pub confirmation_status: Option<ConfirmationStatus>,
	pub txid: Option<Txid>,
}

impl PaymentDetailsUpdate {
Expand All@@ -555,6 +565,7 @@ impl PaymentDetailsUpdate {
 direction: None,
 status: None,
 confirmation_status: None,
 txid: None,
 }
	}
}
Expand All@@ -570,9 +581,9 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 _ => (None, None, None),
 };

 let confirmation_status= match value.kind {
 PaymentKind::Onchain { status, .. } => Some(status),
 _ => None,
 let (confirmation_status, txid) = match &value.kind {
 PaymentKind::Onchain { status, txid, .. } => (Some(*status), Some(*txid)),
 _ => (None, None),
 };

 let counterparty_skimmed_fee_msat = match value.kind {
Expand All@@ -593,6 +604,7 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 direction: Some(value.direction),
 status: Some(value.status),
 confirmation_status,
 txid,
 }
	}
}
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enhance onchain transaction management by Camillarhi · Pull Request #628 · lightningdevkit/ldk-node · GitHub
Skip to content
Enhance onchain transaction management#628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Feb 20, 2026
 Merged


Enhance onchain transaction management
#628
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
38f9a87

Rebroadcast unconfirmed transactions on each new block


Camillarhi Sep 5, 2025
d9d061c

Implement RBF fee bumping for unconfirmed transactions


Camillarhi Jan 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
bindings/ldk_node.udl

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -277,6 +277,8 @@ interface OnchainPayment {
	Txid send_to_address([ByRef]Address address, u64 amount_sats, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid send_all_to_address([ByRef]Address address, boolean retain_reserve, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid bump_fee_rbf(PaymentId payment_id, FeeRate? fee_rate);
};

interface FeeRate {
Expand Down

17 changes: 17 additions & 0 deletions
src/payment/onchain.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use std::sync::{Arc, RwLock};

use bitcoin::{Address, Txid};
use lightning::ln::channelmanager::PaymentId;

use crate::config::Config;
use crate::error::Error;
Expand DownExpand Up@@ -120,4 +121,20 @@ impl OnchainPayment {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.send_to_address(address, send_amount, fee_rate_opt)
	}

	/// Attempt to bump the fee of an unconfirmed transaction using Replace-by-Fee (RBF).
	///
	/// This creates a new transaction that replaces the original one, increasing the fee by the
	/// specified increment to improve its chances of confirmation.
	///
	/// The new transaction will have the same outputs as the original but with a
	/// higher fee, resulting in faster confirmation potential.
	///
	/// Returns the [`Txid`] of the new replacement transaction if successful.
	pub fn bump_fee_rbf(
 &self, payment_id: PaymentId, fee_rate: Option<FeeRate>,
	) -> Result<Txid, Error> {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.bump_fee_rbf(payment_id, fee_rate_opt)
	}
}

11 changes: 6 additions & 5 deletions
src/payment/pending_payment_store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,10 +84,11 @@ impl StorableObjectUpdate<PendingPaymentDetails> for PendingPaymentDetailsUpdate

impl From<&PendingPaymentDetails> for PendingPaymentDetailsUpdate {
	fn from(value: &PendingPaymentDetails) -> Self {
 Self {
 id: value.id(),
 payment_update: Some(value.details.to_update()),
 conflicting_txids: Some(value.conflicting_txids.clone()),
 }
 let conflicting_txids = if value.conflicting_txids.is_empty() {
 None
 } else {
 Some(value.conflicting_txids.clone())
 };
 Self { id: value.id(), payment_update: Some(value.details.to_update()), conflicting_txids }
	}
}

18 changes: 15 additions & 3 deletions
src/payment/store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,6 +291,15 @@ impl StorableObject for PaymentDetails {
 }
 }

 if let Some(tx_id) = update.txid {
 match self.kind {
 PaymentKind::Onchain { ref mut txid, .. } => {
 update_if_necessary!(*txid, tx_id);
 },
 _ => {},
 }
 }

 if updated {
 self.latest_update_timestamp = SystemTime::now()
 .duration_since(UNIX_EPOCH)
Expand DownExpand Up@@ -540,6 +549,7 @@ pub(crate) struct PaymentDetailsUpdate {
	pub direction: Option<PaymentDirection>,
	pub status: Option<PaymentStatus>,
	pub confirmation_status: Option<ConfirmationStatus>,
	pub txid: Option<Txid>,
}

impl PaymentDetailsUpdate {
Expand All@@ -555,6 +565,7 @@ impl PaymentDetailsUpdate {
 direction: None,
 status: None,
 confirmation_status: None,
 txid: None,
 }
	}
}
Expand All@@ -570,9 +581,9 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 _ => (None, None, None),
 };

 let confirmation_status= match value.kind {
 PaymentKind::Onchain { status, .. } => Some(status),
 _ => None,
 let (confirmation_status, txid) = match &value.kind {
 PaymentKind::Onchain { status, txid, .. } => (Some(*status), Some(*txid)),
 _ => (None, None),
 };

 let counterparty_skimmed_fee_msat = match value.kind {
Expand All@@ -593,6 +604,7 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 direction: Some(value.direction),
 status: Some(value.status),
 confirmation_status,
 txid,
 }
	}
}
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enhance onchain transaction management by Camillarhi · Pull Request #628 · lightningdevkit/ldk-node · GitHub
Skip to content
Enhance onchain transaction management#628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Feb 20, 2026
 Merged


Enhance onchain transaction management
#628
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
38f9a87

Rebroadcast unconfirmed transactions on each new block


Camillarhi Sep 5, 2025
d9d061c

Implement RBF fee bumping for unconfirmed transactions


Camillarhi Jan 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
bindings/ldk_node.udl

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -277,6 +277,8 @@ interface OnchainPayment {
	Txid send_to_address([ByRef]Address address, u64 amount_sats, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid send_all_to_address([ByRef]Address address, boolean retain_reserve, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid bump_fee_rbf(PaymentId payment_id, FeeRate? fee_rate);
};

interface FeeRate {
Expand Down

17 changes: 17 additions & 0 deletions
src/payment/onchain.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use std::sync::{Arc, RwLock};

use bitcoin::{Address, Txid};
use lightning::ln::channelmanager::PaymentId;

use crate::config::Config;
use crate::error::Error;
Expand DownExpand Up@@ -120,4 +121,20 @@ impl OnchainPayment {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.send_to_address(address, send_amount, fee_rate_opt)
	}

	/// Attempt to bump the fee of an unconfirmed transaction using Replace-by-Fee (RBF).
	///
	/// This creates a new transaction that replaces the original one, increasing the fee by the
	/// specified increment to improve its chances of confirmation.
	///
	/// The new transaction will have the same outputs as the original but with a
	/// higher fee, resulting in faster confirmation potential.
	///
	/// Returns the [`Txid`] of the new replacement transaction if successful.
	pub fn bump_fee_rbf(
 &self, payment_id: PaymentId, fee_rate: Option<FeeRate>,
	) -> Result<Txid, Error> {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.bump_fee_rbf(payment_id, fee_rate_opt)
	}
}

11 changes: 6 additions & 5 deletions
src/payment/pending_payment_store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,10 +84,11 @@ impl StorableObjectUpdate<PendingPaymentDetails> for PendingPaymentDetailsUpdate

impl From<&PendingPaymentDetails> for PendingPaymentDetailsUpdate {
	fn from(value: &PendingPaymentDetails) -> Self {
 Self {
 id: value.id(),
 payment_update: Some(value.details.to_update()),
 conflicting_txids: Some(value.conflicting_txids.clone()),
 }
 let conflicting_txids = if value.conflicting_txids.is_empty() {
 None
 } else {
 Some(value.conflicting_txids.clone())
 };
 Self { id: value.id(), payment_update: Some(value.details.to_update()), conflicting_txids }
	}
}

18 changes: 15 additions & 3 deletions
src/payment/store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,6 +291,15 @@ impl StorableObject for PaymentDetails {
 }
 }

 if let Some(tx_id) = update.txid {
 match self.kind {
 PaymentKind::Onchain { ref mut txid, .. } => {
 update_if_necessary!(*txid, tx_id);
 },
 _ => {},
 }
 }

 if updated {
 self.latest_update_timestamp = SystemTime::now()
 .duration_since(UNIX_EPOCH)
Expand DownExpand Up@@ -540,6 +549,7 @@ pub(crate) struct PaymentDetailsUpdate {
	pub direction: Option<PaymentDirection>,
	pub status: Option<PaymentStatus>,
	pub confirmation_status: Option<ConfirmationStatus>,
	pub txid: Option<Txid>,
}

impl PaymentDetailsUpdate {
Expand All@@ -555,6 +565,7 @@ impl PaymentDetailsUpdate {
 direction: None,
 status: None,
 confirmation_status: None,
 txid: None,
 }
	}
}
Expand All@@ -570,9 +581,9 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 _ => (None, None, None),
 };

 let confirmation_status= match value.kind {
 PaymentKind::Onchain { status, .. } => Some(status),
 _ => None,
 let (confirmation_status, txid) = match &value.kind {
 PaymentKind::Onchain { status, txid, .. } => (Some(*status), Some(*txid)),
 _ => (None, None),
 };

 let counterparty_skimmed_fee_msat = match value.kind {
Expand All@@ -593,6 +604,7 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 direction: Some(value.direction),
 status: Some(value.status),
 confirmation_status,
 txid,
 }
	}
}
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Enhance onchain transaction management by Camillarhi · Pull Request #628 · lightningdevkit/ldk-node · GitHub
Skip to content
Enhance onchain transaction management#628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Feb 20, 2026
 Merged


Enhance onchain transaction management
#628
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
38f9a87

Rebroadcast unconfirmed transactions on each new block


Camillarhi Sep 5, 2025
d9d061c

Implement RBF fee bumping for unconfirmed transactions


Camillarhi Jan 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
bindings/ldk_node.udl

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -277,6 +277,8 @@ interface OnchainPayment {
	Txid send_to_address([ByRef]Address address, u64 amount_sats, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid send_all_to_address([ByRef]Address address, boolean retain_reserve, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid bump_fee_rbf(PaymentId payment_id, FeeRate? fee_rate);
};

interface FeeRate {
Expand Down

17 changes: 17 additions & 0 deletions
src/payment/onchain.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use std::sync::{Arc, RwLock};

use bitcoin::{Address, Txid};
use lightning::ln::channelmanager::PaymentId;

use crate::config::Config;
use crate::error::Error;
Expand DownExpand Up@@ -120,4 +121,20 @@ impl OnchainPayment {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.send_to_address(address, send_amount, fee_rate_opt)
	}

	/// Attempt to bump the fee of an unconfirmed transaction using Replace-by-Fee (RBF).
	///
	/// This creates a new transaction that replaces the original one, increasing the fee by the
	/// specified increment to improve its chances of confirmation.
	///
	/// The new transaction will have the same outputs as the original but with a
	/// higher fee, resulting in faster confirmation potential.
	///
	/// Returns the [`Txid`] of the new replacement transaction if successful.
	pub fn bump_fee_rbf(
 &self, payment_id: PaymentId, fee_rate: Option<FeeRate>,
	) -> Result<Txid, Error> {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.bump_fee_rbf(payment_id, fee_rate_opt)
	}
}

11 changes: 6 additions & 5 deletions
src/payment/pending_payment_store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,10 +84,11 @@ impl StorableObjectUpdate<PendingPaymentDetails> for PendingPaymentDetailsUpdate

impl From<&PendingPaymentDetails> for PendingPaymentDetailsUpdate {
	fn from(value: &PendingPaymentDetails) -> Self {
 Self {
 id: value.id(),
 payment_update: Some(value.details.to_update()),
 conflicting_txids: Some(value.conflicting_txids.clone()),
 }
 let conflicting_txids = if value.conflicting_txids.is_empty() {
 None
 } else {
 Some(value.conflicting_txids.clone())
 };
 Self { id: value.id(), payment_update: Some(value.details.to_update()), conflicting_txids }
	}
}

18 changes: 15 additions & 3 deletions
src/payment/store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,6 +291,15 @@ impl StorableObject for PaymentDetails {
 }
 }

 if let Some(tx_id) = update.txid {
 match self.kind {
 PaymentKind::Onchain { ref mut txid, .. } => {
 update_if_necessary!(*txid, tx_id);
 },
 _ => {},
 }
 }

 if updated {
 self.latest_update_timestamp = SystemTime::now()
 .duration_since(UNIX_EPOCH)
Expand DownExpand Up@@ -540,6 +549,7 @@ pub(crate) struct PaymentDetailsUpdate {
	pub direction: Option<PaymentDirection>,
	pub status: Option<PaymentStatus>,
	pub confirmation_status: Option<ConfirmationStatus>,
	pub txid: Option<Txid>,
}

impl PaymentDetailsUpdate {
Expand All@@ -555,6 +565,7 @@ impl PaymentDetailsUpdate {
 direction: None,
 status: None,
 confirmation_status: None,
 txid: None,
 }
	}
}
Expand All@@ -570,9 +581,9 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 _ => (None, None, None),
 };

 let confirmation_status= match value.kind {
 PaymentKind::Onchain { status, .. } => Some(status),
 _ => None,
 let (confirmation_status, txid) = match &value.kind {
 PaymentKind::Onchain { status, txid, .. } => (Some(*status), Some(*txid)),
 _ => (None, None),
 };

 let counterparty_skimmed_fee_msat = match value.kind {
Expand All@@ -593,6 +604,7 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 direction: Some(value.direction),
 status: Some(value.status),
 confirmation_status,
 txid,
 }
	}
}
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enhance onchain transaction management by Camillarhi · Pull Request #628 · lightningdevkit/ldk-node · GitHub
Skip to content
Enhance onchain transaction management#628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Feb 20, 2026
 Merged


Enhance onchain transaction management
#628
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
38f9a87

Rebroadcast unconfirmed transactions on each new block


Camillarhi Sep 5, 2025
d9d061c

Implement RBF fee bumping for unconfirmed transactions


Camillarhi Jan 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
bindings/ldk_node.udl

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -277,6 +277,8 @@ interface OnchainPayment {
	Txid send_to_address([ByRef]Address address, u64 amount_sats, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid send_all_to_address([ByRef]Address address, boolean retain_reserve, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid bump_fee_rbf(PaymentId payment_id, FeeRate? fee_rate);
};

interface FeeRate {
Expand Down

17 changes: 17 additions & 0 deletions
src/payment/onchain.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use std::sync::{Arc, RwLock};

use bitcoin::{Address, Txid};
use lightning::ln::channelmanager::PaymentId;

use crate::config::Config;
use crate::error::Error;
Expand DownExpand Up@@ -120,4 +121,20 @@ impl OnchainPayment {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.send_to_address(address, send_amount, fee_rate_opt)
	}

	/// Attempt to bump the fee of an unconfirmed transaction using Replace-by-Fee (RBF).
	///
	/// This creates a new transaction that replaces the original one, increasing the fee by the
	/// specified increment to improve its chances of confirmation.
	///
	/// The new transaction will have the same outputs as the original but with a
	/// higher fee, resulting in faster confirmation potential.
	///
	/// Returns the [`Txid`] of the new replacement transaction if successful.
	pub fn bump_fee_rbf(
 &self, payment_id: PaymentId, fee_rate: Option<FeeRate>,
	) -> Result<Txid, Error> {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.bump_fee_rbf(payment_id, fee_rate_opt)
	}
}

11 changes: 6 additions & 5 deletions
src/payment/pending_payment_store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,10 +84,11 @@ impl StorableObjectUpdate<PendingPaymentDetails> for PendingPaymentDetailsUpdate

impl From<&PendingPaymentDetails> for PendingPaymentDetailsUpdate {
	fn from(value: &PendingPaymentDetails) -> Self {
 Self {
 id: value.id(),
 payment_update: Some(value.details.to_update()),
 conflicting_txids: Some(value.conflicting_txids.clone()),
 }
 let conflicting_txids = if value.conflicting_txids.is_empty() {
 None
 } else {
 Some(value.conflicting_txids.clone())
 };
 Self { id: value.id(), payment_update: Some(value.details.to_update()), conflicting_txids }
	}
}

18 changes: 15 additions & 3 deletions
src/payment/store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,6 +291,15 @@ impl StorableObject for PaymentDetails {
 }
 }

 if let Some(tx_id) = update.txid {
 match self.kind {
 PaymentKind::Onchain { ref mut txid, .. } => {
 update_if_necessary!(*txid, tx_id);
 },
 _ => {},
 }
 }

 if updated {
 self.latest_update_timestamp = SystemTime::now()
 .duration_since(UNIX_EPOCH)
Expand DownExpand Up@@ -540,6 +549,7 @@ pub(crate) struct PaymentDetailsUpdate {
	pub direction: Option<PaymentDirection>,
	pub status: Option<PaymentStatus>,
	pub confirmation_status: Option<ConfirmationStatus>,
	pub txid: Option<Txid>,
}

impl PaymentDetailsUpdate {
Expand All@@ -555,6 +565,7 @@ impl PaymentDetailsUpdate {
 direction: None,
 status: None,
 confirmation_status: None,
 txid: None,
 }
	}
}
Expand All@@ -570,9 +581,9 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 _ => (None, None, None),
 };

 let confirmation_status= match value.kind {
 PaymentKind::Onchain { status, .. } => Some(status),
 _ => None,
 let (confirmation_status, txid) = match &value.kind {
 PaymentKind::Onchain { status, txid, .. } => (Some(*status), Some(*txid)),
 _ => (None, None),
 };

 let counterparty_skimmed_fee_msat = match value.kind {
Expand All@@ -593,6 +604,7 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 direction: Some(value.direction),
 status: Some(value.status),
 confirmation_status,
 txid,
 }
	}
}
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enhance onchain transaction management by Camillarhi · Pull Request #628 · lightningdevkit/ldk-node · GitHub
Skip to content
Enhance onchain transaction management#628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Feb 20, 2026
 Merged


Enhance onchain transaction management
#628
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
38f9a87

Rebroadcast unconfirmed transactions on each new block


Camillarhi Sep 5, 2025
d9d061c

Implement RBF fee bumping for unconfirmed transactions


Camillarhi Jan 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
bindings/ldk_node.udl

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -277,6 +277,8 @@ interface OnchainPayment {
	Txid send_to_address([ByRef]Address address, u64 amount_sats, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid send_all_to_address([ByRef]Address address, boolean retain_reserve, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid bump_fee_rbf(PaymentId payment_id, FeeRate? fee_rate);
};

interface FeeRate {
Expand Down

17 changes: 17 additions & 0 deletions
src/payment/onchain.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use std::sync::{Arc, RwLock};

use bitcoin::{Address, Txid};
use lightning::ln::channelmanager::PaymentId;

use crate::config::Config;
use crate::error::Error;
Expand DownExpand Up@@ -120,4 +121,20 @@ impl OnchainPayment {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.send_to_address(address, send_amount, fee_rate_opt)
	}

	/// Attempt to bump the fee of an unconfirmed transaction using Replace-by-Fee (RBF).
	///
	/// This creates a new transaction that replaces the original one, increasing the fee by the
	/// specified increment to improve its chances of confirmation.
	///
	/// The new transaction will have the same outputs as the original but with a
	/// higher fee, resulting in faster confirmation potential.
	///
	/// Returns the [`Txid`] of the new replacement transaction if successful.
	pub fn bump_fee_rbf(
 &self, payment_id: PaymentId, fee_rate: Option<FeeRate>,
	) -> Result<Txid, Error> {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.bump_fee_rbf(payment_id, fee_rate_opt)
	}
}

11 changes: 6 additions & 5 deletions
src/payment/pending_payment_store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,10 +84,11 @@ impl StorableObjectUpdate<PendingPaymentDetails> for PendingPaymentDetailsUpdate

impl From<&PendingPaymentDetails> for PendingPaymentDetailsUpdate {
	fn from(value: &PendingPaymentDetails) -> Self {
 Self {
 id: value.id(),
 payment_update: Some(value.details.to_update()),
 conflicting_txids: Some(value.conflicting_txids.clone()),
 }
 let conflicting_txids = if value.conflicting_txids.is_empty() {
 None
 } else {
 Some(value.conflicting_txids.clone())
 };
 Self { id: value.id(), payment_update: Some(value.details.to_update()), conflicting_txids }
	}
}

18 changes: 15 additions & 3 deletions
src/payment/store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,6 +291,15 @@ impl StorableObject for PaymentDetails {
 }
 }

 if let Some(tx_id) = update.txid {
 match self.kind {
 PaymentKind::Onchain { ref mut txid, .. } => {
 update_if_necessary!(*txid, tx_id);
 },
 _ => {},
 }
 }

 if updated {
 self.latest_update_timestamp = SystemTime::now()
 .duration_since(UNIX_EPOCH)
Expand DownExpand Up@@ -540,6 +549,7 @@ pub(crate) struct PaymentDetailsUpdate {
	pub direction: Option<PaymentDirection>,
	pub status: Option<PaymentStatus>,
	pub confirmation_status: Option<ConfirmationStatus>,
	pub txid: Option<Txid>,
}

impl PaymentDetailsUpdate {
Expand All@@ -555,6 +565,7 @@ impl PaymentDetailsUpdate {
 direction: None,
 status: None,
 confirmation_status: None,
 txid: None,
 }
	}
}
Expand All@@ -570,9 +581,9 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 _ => (None, None, None),
 };

 let confirmation_status= match value.kind {
 PaymentKind::Onchain { status, .. } => Some(status),
 _ => None,
 let (confirmation_status, txid) = match &value.kind {
 PaymentKind::Onchain { status, txid, .. } => (Some(*status), Some(*txid)),
 _ => (None, None),
 };

 let counterparty_skimmed_fee_msat = match value.kind {
Expand All@@ -593,6 +604,7 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 direction: Some(value.direction),
 status: Some(value.status),
 confirmation_status,
 txid,
 }
	}
}
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Enhance onchain transaction management by Camillarhi · Pull Request #628 · lightningdevkit/ldk-node · GitHub
Skip to content
Enhance onchain transaction management#628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Feb 20, 2026
 Merged


Enhance onchain transaction management
#628
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
38f9a87

Rebroadcast unconfirmed transactions on each new block


Camillarhi Sep 5, 2025
d9d061c

Implement RBF fee bumping for unconfirmed transactions


Camillarhi Jan 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
bindings/ldk_node.udl

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -277,6 +277,8 @@ interface OnchainPayment {
	Txid send_to_address([ByRef]Address address, u64 amount_sats, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid send_all_to_address([ByRef]Address address, boolean retain_reserve, FeeRate? fee_rate);
	[Throws=NodeError]
	Txid bump_fee_rbf(PaymentId payment_id, FeeRate? fee_rate);
};

interface FeeRate {
Expand Down

17 changes: 17 additions & 0 deletions
src/payment/onchain.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use std::sync::{Arc, RwLock};

use bitcoin::{Address, Txid};
use lightning::ln::channelmanager::PaymentId;

use crate::config::Config;
use crate::error::Error;
Expand DownExpand Up@@ -120,4 +121,20 @@ impl OnchainPayment {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.send_to_address(address, send_amount, fee_rate_opt)
	}

	/// Attempt to bump the fee of an unconfirmed transaction using Replace-by-Fee (RBF).
	///
	/// This creates a new transaction that replaces the original one, increasing the fee by the
	/// specified increment to improve its chances of confirmation.
	///
	/// The new transaction will have the same outputs as the original but with a
	/// higher fee, resulting in faster confirmation potential.
	///
	/// Returns the [`Txid`] of the new replacement transaction if successful.
	pub fn bump_fee_rbf(
 &self, payment_id: PaymentId, fee_rate: Option<FeeRate>,
	) -> Result<Txid, Error> {
 let fee_rate_opt = maybe_map_fee_rate_opt!(fee_rate);
 self.wallet.bump_fee_rbf(payment_id, fee_rate_opt)
	}
}

11 changes: 6 additions & 5 deletions
src/payment/pending_payment_store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,10 +84,11 @@ impl StorableObjectUpdate<PendingPaymentDetails> for PendingPaymentDetailsUpdate

impl From<&PendingPaymentDetails> for PendingPaymentDetailsUpdate {
	fn from(value: &PendingPaymentDetails) -> Self {
 Self {
 id: value.id(),
 payment_update: Some(value.details.to_update()),
 conflicting_txids: Some(value.conflicting_txids.clone()),
 }
 let conflicting_txids = if value.conflicting_txids.is_empty() {
 None
 } else {
 Some(value.conflicting_txids.clone())
 };
 Self { id: value.id(), payment_update: Some(value.details.to_update()), conflicting_txids }
	}
}

18 changes: 15 additions & 3 deletions
src/payment/store.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -291,6 +291,15 @@ impl StorableObject for PaymentDetails {
 }
 }

 if let Some(tx_id) = update.txid {
 match self.kind {
 PaymentKind::Onchain { ref mut txid, .. } => {
 update_if_necessary!(*txid, tx_id);
 },
 _ => {},
 }
 }

 if updated {
 self.latest_update_timestamp = SystemTime::now()
 .duration_since(UNIX_EPOCH)
Expand DownExpand Up@@ -540,6 +549,7 @@ pub(crate) struct PaymentDetailsUpdate {
	pub direction: Option<PaymentDirection>,
	pub status: Option<PaymentStatus>,
	pub confirmation_status: Option<ConfirmationStatus>,
	pub txid: Option<Txid>,
}

impl PaymentDetailsUpdate {
Expand All@@ -555,6 +565,7 @@ impl PaymentDetailsUpdate {
 direction: None,
 status: None,
 confirmation_status: None,
 txid: None,
 }
	}
}
Expand All@@ -570,9 +581,9 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 _ => (None, None, None),
 };

 let confirmation_status= match value.kind {
 PaymentKind::Onchain { status, .. } => Some(status),
 _ => None,
 let (confirmation_status, txid) = match &value.kind {
 PaymentKind::Onchain { status, txid, .. } => (Some(*status), Some(*txid)),
 _ => (None, None),
 };

 let counterparty_skimmed_fee_msat = match value.kind {
Expand All@@ -593,6 +604,7 @@ impl From<&PaymentDetails> for PaymentDetailsUpdate {
 direction: Some(value.direction),
 status: Some(value.status),
 confirmation_status,
 txid,
 }
	}
}
Expand Down
Loading
Loading